Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: support native watcher #8455

Open
hardfist opened this issue Nov 18, 2024 · 4 comments
Open

[Feature]: support native watcher #8455

hardfist opened this issue Nov 18, 2024 · 4 comments
Assignees

Comments

@hardfist
Copy link
Contributor

What problem does this feature solve?

we currently use watchpack and it has performance issue especially when killed by ctrl-c, it may even take seconds to shutdown, we can progressively migrate watchpack to native watchers

What does the proposed API of configuration look like?

experiments: {
   nativeWatcher: true
}

we can reuse Watch and watchOptions

@hardfist hardfist added feat New feature or request pending triage The issue/PR is currently untouched. labels Nov 18, 2024
@hardfist hardfist changed the title [Feature]: support native watchers [Feature]: support native watcher Nov 18, 2024
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Nov 18, 2024
@hardfist hardfist removed feat New feature or request team The issue/pr is created by the member of Rspack. pending triage The issue/PR is currently untouched. labels Nov 18, 2024
@ClSlaid
Copy link

ClSlaid commented Nov 19, 2024

I don't see any native file wather implementation in rspack, is that already done?

If the watcher does not exist, we can implement that with watch-exec

@hardfist
Copy link
Contributor Author

hardfist commented Nov 25, 2024

I don't see any native file wather implementation in rspack, is that already done?
No, haven't started yet

If the watcher does not exist, we can implement that with watch-exec

yes, watch-exec seems a good choice, but since rspack don't rely on watcher to start new process, maybe use notify directly would be much light and bring small crated size increase

@ClSlaid are you interested in implementing this feature

@ClSlaid
Copy link

ClSlaid commented Nov 25, 2024

I'd like to have a look, but I can only proceed with that in my spare time. See if I can implement it in 2 or 3 weeks.

@hardfist
Copy link
Contributor Author

@ClSlaid take your time, it's not a urgent feature right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants