Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support --lib param of mf-dev command #590

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: support --lib param of mf-dev command #590

wants to merge 3 commits into from
+360 −155

Conversation

Timeless0911
Copy link
Collaborator

@Timeless0911 Timeless0911 commented Dec 22, 2024 •
edited
Loading

Summary

  • Modify mf dev command name to mf-dev to accect more params
  • Support --lib param of mf-dev command
  • Use EnvironmentConfig type in lib field
  • Use EnvironmentConfig instead of RsbuildConfig types in composing Rsbuild config in Rslib internal logic
  • Put below config to outside of environments config since they are global configuration of Rsbuild
    • mode
    • root
    • dev
    • plugins
    • server

Related Links

closes: #513
closes: #555

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@Timeless0911 Timeless0911 force-pushed the feature/support-mf-dev-lib branch from 23130d5 to ee16ba9 Compare December 22, 2024 14:14
@netlify Netlify
Copy link

netlify bot commented Dec 22, 2024

✅ Deploy Preview for rslib ready!

Name Link
🔨 Latest commit a735c83
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/67681e8f4b79910008e99092
😎 Deploy Preview https://deploy-preview-590--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Timeless0911 Timeless0911 marked this pull request as ready for review December 22, 2024 14:17
@netlify Netlify
Copy link

netlify bot commented Dec 22, 2024 •
edited
Loading

✅ Deploy Preview for rslib ready!

Name Link
🔨 Latest commit 83bcfd5
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/67682260b5b2830008a179dc
😎 Deploy Preview https://deploy-preview-590--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Timeless0911 Timeless0911 force-pushed the feature/support-mf-dev-lib branch from f3cf56b to 83bcfd5 Compare December 22, 2024 14:29
@Timeless0911 Timeless0911 marked this pull request as draft December 22, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
change: feat
Projects
None yet
Milestone
No milestone
1 participant
@Timeless0911