Issues with eslint in mono repository

[bmoellers]

Hi all,

Need some help. So I originally set up a Next JS project and I am in the process of converting only the remotes over to Modern-JS. Most things work really well but the problem that under turborepo, the eslint is not running for modern js. It gets the following error.

modern-drop-in-ui:lint: $ modern lint
modern-drop-in-ui:lint: Modern.js Framework v2.48.4
modern-drop-in-ui:lint:
modern-drop-in-ui:lint: info Lint...
modern-drop-in-ui:lint: info NODE_OPTIONS="--max-old-space-size=8192" /Users/BMoellers/code/payment-service-drop-in-ui/node_modules/eslint/bin/eslint.js --ext .js,.jsx,.ts,.tsx,.mjs,.mjsx,.cjs,.cjsx --fix --ignore-pattern node_modules/ --ignore-pattern dist/ --ignore-pattern output/ --ignore-pattern output_resource/ ./
modern-drop-in-ui:lint:
modern-drop-in-ui:lint: Oops! Something went wrong! :(
modern-drop-in-ui:lint:
modern-drop-in-ui:lint: ESLint: 7.32.0
modern-drop-in-ui:lint:
modern-drop-in-ui:lint: ESLint couldn't find the plugin "eslint-plugin-eslint-comments".
modern-drop-in-ui:lint:
modern-drop-in-ui:lint: (The package "eslint-plugin-eslint-comments" was not found when loaded as a Node module from the directory "/Users/BMoellers/code/payment-service-drop-in-ui/apps/modern-drop-in-ui".)
modern-drop-in-ui:lint:
modern-drop-in-ui:lint: It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
modern-drop-in-ui:lint:
modern-drop-in-ui:lint: npm install eslint-plugin-eslint-comments@latest --save-dev
modern-drop-in-ui:lint:
modern-drop-in-ui:lint: The plugin "eslint-plugin-eslint-comments" was referenced from the config file in ".eslintrc.js » @modern-js/eslint-config » @modern-js-app/eslint-config/base".
modern-drop-in-ui:lint:
modern-drop-in-ui:lint: If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.
modern-drop-in-ui:lint:
modern-drop-in-ui:lint: info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
modern-drop-in-ui:lint: error Command failed with exit code 2.
modern-drop-in-ui:lint: ERROR: command finished with error: command (/Users/BMoellers/code/payment-service-drop-in-ui/apps/modern-drop-in-ui) yarn run lint exited (2)

I cannot share my companies repository for probably obvious reasons but what I did was create a Next JS mono repo app using turborepo. Then I created a new app then ran the setup for the ModernJS application. The build works fine and the new host are imported fine in our NextJS sandbox (the rest of the company uses NextJs but we were given permission to use ModernJS for better MFE support). This causes the ES lint error.

So I did try the mono repo setup from Modern JS and that does run lint correctly on the ModernJS web app under its apps directory. That just runs modern lint from the top directory. I cannot do that because I have a nextjs app and a react app in the mono repository.

Any ideas on how to fix this or any examples of a mixed monorepo that can be shown?

I will work on getting permission to share something simple that exhibits this issue without revealing any secrets but hoping I can resolve this. I really hate NextJS and MFE support but if I cannot I will move back to trying to get that working.