Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notifications #632

Open
2 tasks
edenvidal opened this issue Feb 27, 2024 · 7 comments
Open
2 tasks

notifications #632

edenvidal opened this issue Feb 27, 2024 · 7 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@edenvidal
Copy link
Member

edenvidal commented Feb 27, 2024

  • design and add to rnbw.design where it is relevant
  • "rnbw couldn't find the source file..." - should be a notification. (@atulbhatt-system32 )
@edenvidal edenvidal self-assigned this Feb 27, 2024
@edenvidal edenvidal removed their assignment Mar 19, 2024
@atulbhatt-system32
Copy link
Contributor

sure @edenvidal that'll made a notification.

@atulbhatt-system32 atulbhatt-system32 self-assigned this Mar 20, 2024
@atulbhatt-system32 atulbhatt-system32 added the enhancement New feature or request label Mar 20, 2024
@stanislavasal
Copy link
Contributor

  • design and add to guide.rnbw.dev where it is relevant
  • "rnbw couldn't find the source file..." - should be a notification. (@atulbhatt-system32 )

@edenvidal @atulbhatt-system32 hello! do I need to design it in Figma?

@stanislavasal
Copy link
Contributor

@atulbhatt-system32
Copy link
Contributor

@stanislavasal
https://fkhadra.github.io/react-toastify/introduction/

This is the library we are using currently for notification.
You can try creating custom notification using it to match the design you created.

Now there are going to be different type of notifications. Here it's kinda informing and waiting for user to confirm that they have read it. While there are some notification which are simply there to inform the user that something happened.

Like user did some action like "Download" a project. So you can see how you can fit various use cases of notifications.

@edenvidal
Copy link
Member Author

edenvidal commented Apr 10, 2024

@stanislavasal maybe let's find the right place in the guide to design a notification on one of the shots (maybe the stage section wince its empty?)
let's remove the description. we'll solely going to apply rene.css classes on the objects (:
also, let's make the position of the nofification in the bottom center (currently, it is bottom right)
let's make the notification as simple as in here
Image

@atulbhatt-system32 atulbhatt-system32 removed their assignment Apr 13, 2024
@edenvidal edenvidal changed the title design - notifications notifications Apr 16, 2024
@edenvidal
Copy link
Member Author

let's remove the component we're using for notifications. instead, let's create our own stupid design like in figma and simply have this shown up when there's something. (no need for another dependency)

@edenvidal
Copy link
Member Author

@maxdnc, check this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: Next Up
Development

No branches or pull requests

4 participants