Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide MMAP alternative #1

Open
waveform80 opened this issue Feb 22, 2014 · 0 comments
Open

Provide MMAP alternative #1

waveform80 opened this issue Feb 22, 2014 · 0 comments
Assignees
@waveform80
Labels
enhancement
Milestone
1.0

Comments

@waveform80
Copy link
Member

When CompoundFileReader is constructed with a "real" file (i.e. something that returns an fd from fileno()), we should mmap the file and just read the bits of the FAT that we require in response to read requests from constructed streams. This should be considerably more efficient than constructing the entire FAT in memory
@waveform80 waveform80 added this to the 0.2 milestone Feb 22, 2014
@waveform80 waveform80 self-assigned this Feb 22, 2014
waveform80 added a commit that referenced this issue Mar 4, 2014
@waveform80
Fix #4
0af8418 
Switched implementation to mmap.  All underlying reads are mmap-based so
duplication of file pointers is gone and multiple threads can
simultaneously access the compound document.

Note that #1 is not fixed by this as we still read the entire FAT into
memory upon initial access.
@waveform80 waveform80 modified the milestones: 0.3, 0.2 Apr 22, 2014
@waveform80 waveform80 modified the milestones: 1.0, 0.3 Sep 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@waveform80 waveform80

Labels
enhancement
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@waveform80