Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't ask me again checkbox #776

Open
nikhilNathwani opened this issue May 13, 2014 · 3 comments
Open

Don't ask me again checkbox #776

nikhilNathwani opened this issue May 13, 2014 · 3 comments

Comments

@nikhilNathwani
Copy link
Contributor

When the user chooses a file in the "new array from CSV" block from the block menu's Array category, they are shown a security alert with the message: "Your potentially sensitive data will be uploaded to the server. Continue?"

This ideally should not happen every time a user clicks the "Choose File" button. It'd be nice to have a "Do not ask me again" checkbox in the alert that prevents it from being shown for the duration of the session.

@CelticMinstrel
Copy link
Contributor

Is this a browser-controlled dialog? Because that might make it hard to get around. Or is it Watervear showing this using the confirm() function or something?

@nikhilNathwani
Copy link
Contributor Author

It's a call to the confirm() function in scripts/block.js

@CelticMinstrel
Copy link
Contributor

I don't think we can have a "don't ask me again" checkbox, then, unless we want to complicate things by creating our own dialog in the DOM. (I've actually done this for something unrelated to waterbear, but the nice thing about confirm() is that it's synchronous, so you can continue to do more stuff afterwards.)

@dethe dethe modified the milestones: 1.0 Launch, Beta + IDE Jul 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants