Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Enable support for multiple engines #5261

Open
xdoardo opened this issue Nov 19, 2024 — with Linear · 0 comments · May be fixed by #5243
Open

CLI: Enable support for multiple engines #5261

xdoardo opened this issue Nov 19, 2024 — with Linear · 0 comments · May be fixed by #5243
Assignees
Labels
Feature 📦 lib-cli About wasmer-cli

Comments

Copy link
Contributor

xdoardo commented Nov 19, 2024

Right now the CLI is structured around "compilers". We should change this concept to revolve around runtimes. For example, we have the type

#[cfg(feature = "compiler")]
#[derive(Debug, Clone, clap::Parser, Default)]
/// The compiler options
pub struct CompilerOptions {
    /// Use Singlepass compiler.
    #[clap(long, conflicts_with_all = &["cranelift", "llvm"])]
    singlepass: bool,

    /// Use Cranelift compiler.
    #[clap(long, conflicts_with_all = &["singlepass", "llvm"])]
    cranelift: bool,

    /// Use LLVM compiler.
    #[clap(long, conflicts_with_all = &["singlepass", "cranelift"])]
    llvm: bool,

   ...
}

And it should take into account other runtimes (V8, wamr, wasmi) as well.

@xdoardo xdoardo added Feature 📦 lib-cli About wasmer-cli labels Nov 19, 2024 — with Linear
@xdoardo xdoardo self-assigned this Nov 19, 2024
@xdoardo xdoardo linked a pull request Nov 22, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature 📦 lib-cli About wasmer-cli
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant