Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outgoing Content-Type is not scoped #127

Open
warriordog opened this issue Nov 4, 2023 · 1 comment
Open

Outgoing Content-Type is not scoped #127

warriordog opened this issue Nov 4, 2023 · 1 comment
Assignees
Labels
area:code Affects or applies to the library code good first issue Good for newcomers type:bug Something isn't working

Comments

@warriordog
Copy link
Owner

warriordog commented Nov 4, 2023

According to the spec, the acceptable content types are:

  • application/ld+json; profile="https://www.w3.org/ns/activitystreams"
  • application/activity+json

The latter type is described as optional, and implementations are not required to support it.
For best results, it's recommended to accept either form but use the first for outgoing requests.

Our implementation currently supports only the second, unscoped type along with these extra types for maximum compatibility:

  • application/activity+json
  • application/ld+json
  • application/json

This works against all tested Fedi implementations, but we should include the profile for better spec-compliance. This may require a refactor of ActivityPubOptions.

See also: https://www.w3.org/TR/activitypub/#client-to-server-interactions

@warriordog warriordog added type:bug Something isn't working good first issue Good for newcomers area:code Affects or applies to the library code labels Nov 4, 2023
@puzzler995
Copy link

I'll pick this one up and work on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:code Affects or applies to the library code good first issue Good for newcomers type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants