chore(weave): ruff: enable C419 (#2908)

Author: andrewtruong

examples/weaveflow/get_started.ipynb

@@ -157,7 +157,7 @@
     "@weave.op()\n",
     "def aggregate_scores(score_dicts) -> float:\n",
     "    return sum(\n",
-    "        [score_dict[\"brevity\"] * score_dict[\"relevance\"] for score_dict in score_dicts]\n",
+    "        score_dict[\"brevity\"] * score_dict[\"relevance\"] for score_dict in score_dicts\n",
     "    ) / len(score_dicts)\n",
     "\n",
     "\n",

pyproject.toml

@@ -169,6 +169,7 @@ select = [
   "UP",     # https://docs.astral.sh/ruff/rules/#pyupgrade-up
   "C409",   # https://docs.astral.sh/ruff/rules/unnecessary-literal-within-tuple-call/
   "C400",   # https://docs.astral.sh/ruff/rules/unnecessary-generator-list/
+  "C419",   # https://docs.astral.sh/ruff/rules/unnecessary-comprehension-in-call/
 ]
 ignore = [
   # we use Google style

tests/trace/test_client_trace.py

@@ -334,7 +334,7 @@ def liner(m: Number, b, x) -> Number:
     run_calls += num_calls * 3
     root_calls += num_calls
 
-    total_calls = sum([op_call.num_calls for op_call in result.values()])
+    total_calls = sum(op_call.num_calls for op_call in result.values())
 
     return OpCallSpec(
         call_summaries=result,
@@ -409,7 +409,7 @@ def test_trace_call_query_filter_op_version_refs(client):
 
 
 def has_any(list_a: list[str], list_b: list[str]) -> bool:
-    return any([a in list_b for a in list_a])
+    return any(a in list_b for a in list_a)
 
 
 def unique_vals(list_a: list[str]) -> list[str]:
@@ -425,7 +425,7 @@ def get_all_calls_asserting_finished(
         )
     )
     assert len(res.calls) == call_spec.total_calls
-    assert all([call.ended_at for call in res.calls])
+    assert all(call.ended_at for call in res.calls)
     return res
 
 

tests/trace/test_objs_query.py

@@ -30,7 +30,7 @@ def test_objs_query_filter_object_ids(client: WeaveClient):
         )
     )
     assert len(res.objs) == 20
-    assert all([obj.object_id in ["obj_0", "obj_1"] for obj in res.objs])
+    assert all(obj.object_id in ["obj_0", "obj_1"] for obj in res.objs)
 
 
 def test_objs_query_filter_is_op(client: WeaveClient):
@@ -60,8 +60,8 @@ def test_objs_query_filter_latest_only(client: WeaveClient):
         )
     )
     assert len(res.objs) == 10
-    assert all([obj.is_latest for obj in res.objs])
-    assert all([obj.val["j"] == 9 for obj in res.objs])
+    assert all(obj.is_latest for obj in res.objs)
+    assert all(obj.val["j"] == 9 for obj in res.objs)
 
 
 def test_objs_query_filter_limit_offset_sort_by_created_at(client: WeaveClient):
@@ -77,7 +77,7 @@ def test_objs_query_filter_limit_offset_sort_by_created_at(client: WeaveClient):
         )
     )
     assert len(res.objs) == 3
-    assert all([obj.is_latest for obj in res.objs])
+    assert all(obj.is_latest for obj in res.objs)
     assert res.objs[0].val["j"] == 9
     assert res.objs[0].val["i"] == 4
     assert res.objs[1].val["j"] == 9
@@ -95,7 +95,7 @@ def test_objs_query_filter_limit_offset_sort_by_created_at(client: WeaveClient):
         )
     )
     assert len(res.objs) == 3
-    assert all([obj.is_latest for obj in res.objs])
+    assert all(obj.is_latest for obj in res.objs)
     assert res.objs[0].val["j"] == 9
     assert res.objs[0].val["i"] == 5
     assert res.objs[1].val["j"] == 9
@@ -117,7 +117,7 @@ def test_objs_query_filter_limit_offset_sort_by_object_id(client: WeaveClient):
         )
     )
     assert len(res.objs) == 3
-    assert all([obj.is_latest for obj in res.objs])
+    assert all(obj.is_latest for obj in res.objs)
     assert res.objs[0].val["j"] == 9
     assert res.objs[0].val["i"] == 4
     assert res.objs[1].val["j"] == 9
@@ -135,7 +135,7 @@ def test_objs_query_filter_limit_offset_sort_by_object_id(client: WeaveClient):
         )
     )
     assert len(res.objs) == 3
-    assert all([obj.is_latest for obj in res.objs])
+    assert all(obj.is_latest for obj in res.objs)
     assert res.objs[0].val["j"] == 9
     assert res.objs[0].val["i"] == 5
     assert res.objs[1].val["j"] == 9