Merge pull request #10 from Zedifuu/bugfix/outdated-build

Fixed outdated build script and fixed compatibility with Python 3.10 and 3.12

Author: flozz

.github/workflows/pontoon-tarball.yml

@@ -26,22 +26,23 @@ jobs:
       - name: "Checkout the repository"
         uses: actions/checkout@v4
 
-      - name: "Set up Python 3.11"
-        uses: actions/setup-python@v5
-        with:
-          python-version: "3.11"
+      - name: Install uv
+        uses: astral-sh/setup-uv@v4
+
+      - name: Set up Python 3.11
+        run: uv python install 3.11
 
-      - name: "Set up Node 16"
+      - name: "Set up Node 20"
         uses: actions/setup-node@v4
         with:
-          node-version: 16
+          node-version: 20
 
       - name: "Make Pontoon release tarball"
         run: |
           ./make-pontoon-tarball.sh
 
       - name: "Upload artifacts"
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: pontoon-release-tarball
           path: ./dist/
@@ -84,7 +85,7 @@ jobs:
           python-version: ${{ matrix.python-version }}
 
       - name: "Download Pontoon release tarball"
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
           name: pontoon-release-tarball
 
@@ -102,6 +103,8 @@ jobs:
       - name: "Install Python dependencies"
         run: |
           cd pontoon-*
+          python -m pip install pip-tools
+          pip-compile --generate-hashes requirements/default.in -o requirements/default.txt
           pip install -r requirements.txt
 
       - name: "Make DB Migration"

Dockerfile

@@ -1,24 +1,17 @@
-FROM ubuntu:22.04
+FROM python:3.11-bookworm
+COPY --from=ghcr.io/astral-sh/uv:latest /uv /uvx /bin/
 
 ENV DEBIAN_FRONTEND=noninteractive
 
-RUN apt-get update && \
+RUN mkdir -p /etc/apt/keyrings && \
+    curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg && \
+    echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_20.x nodistro main" | tee /etc/apt/sources.list.d/nodesource.list && \
+    apt-get update && \
     apt-get install -y \
         build-essential \
-        ca-certificates \
-        curl \
         git \
-        gnupg \
         libpq-dev \
-        python3 \
-        python3-dev \
-        python3-venv \
-        && \
-    mkdir -p /etc/apt/keyrings && \
-    curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | gpg --dearmor -o /etc/apt/keyrings/nodesource.gpg && \
-    echo "deb [signed-by=/etc/apt/keyrings/nodesource.gpg] https://deb.nodesource.com/node_20.x nodistro main" | tee /etc/apt/sources.list.d/nodesource.list && \
-    apt-get update && \
-    apt-get install -y nodejs
+        nodejs
 
 WORKDIR /data
 

debian/requirements.py310.in

@@ -0,0 +1,10 @@
+# This file must be copied to the root of the Pontoon's repository,
+# Then the requirements.py310.txt can be generated with the following command:
+#
+#     uv pip compile --generate-hashes requirements.py310.in -o requirements.py310.txt
+#
+
+-r requirements.txt
+
+# Python 3.10 additional dependency for anyio
+exceptiongroup==1.2.2

make-pontoon-tarball.sh

@@ -33,11 +33,35 @@ git clone https://github.com/mozilla/pontoon.git $BUILD_DIR/$APP_NAME.git
 cd $BUILD_DIR/$APP_NAME.git
 git checkout $PONTOON_REV
 
-# Install Python dependencies
-python3 -m venv __env__
+# Prepare Python Virtual Environment using uv if available else using venv
+uv --version > /dev/null 2>&1 && uv venv __env__ || python3 -m venv __env__
 source __env__/bin/activate
-pip install --upgrade pip==23.1.1  # Pip version fixed because it breaks pip-tools everytime...
-pip install -r requirements.txt
+
+# Collect info about the environment
+PYTHON_MAJOR=$(python -c "import sys;print(sys.version_info.major)")
+PYTHON_MINOR=$(python -c "import sys;print(sys.version_info.minor)")
+uv --version > /dev/null 2>&1 && UV_AVAILABLE=1 || UV_AVAILABLE=0
+
+# Install uv in the venv if not available
+if [ $UV_AVAILABLE != 1 ] ; then
+   pip install uv
+fi
+
+# Compile dependencies (Replicating: https://github.com/mozilla/pontoon/blob/d619331f62b28fd69d3f998d97e4343dd0ed6bc4/docker/compile_requirements.sh)
+uv pip compile --generate-hashes requirements/default.in -o requirements/default.txt
+uv pip compile --generate-hashes requirements/dev.in -o requirements/dev.txt
+uv pip compile --generate-hashes requirements/lint.in -o requirements/lint.txt
+uv pip compile --generate-hashes requirements/test.in -o requirements/test.txt
+
+# Compile additional dependencies for Python 3.10
+cp $DEBIAN_DIR/requirements.py310.in $BUILD_DIR/$APP_NAME.git/
+uv pip compile --generate-hashes $BUILD_DIR/$APP_NAME.git/requirements.py310.in -o $OUTPUT_DIR/requirements.py310.txt
+
+# Install Python dependencies
+uv pip install -r requirements.txt
+if [ $PYTHON_MAJOR == 3 ] && [ $PYTHON_MINOR -ge 12 ] ; then
+    uv pip install setuptools
+fi
 
 # Install Node dependencies
 npm install
@@ -49,19 +73,17 @@ export DJANGO_DEBUG=True
 
 # Build the front
 npm run build:prod
-python3 manage.py collectstatic
+uv run manage.py collectstatic
 
 # Leave the virtualenv
 deactivate
 
 # Copy files
 cp -vr static/ $OUTPUT_DIR
 cp -vr pontoon/ $OUTPUT_DIR
-cp -vr tag-admin/ $OUTPUT_DIR
 cp -vr translate/ $OUTPUT_DIR
 cp -vr requirements/ $OUTPUT_DIR
 cp -v setup.py $OUTPUT_DIR
-cp -v setup.cfg $OUTPUT_DIR
 cp -v manage.py $OUTPUT_DIR
 cp -v requirements.txt $OUTPUT_DIR
 cp -v LICENSE $OUTPUT_DIR