concord client v2 #810
Merged
concord client v2 #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brig
force-pushed
the
brig/concord-client2
branch
from
61a6da7 to
2dbe0a4
Compare
ibodrov
approved these changes
Oct 9, 2023
| <configuration> | ||
| <skip>true</skip> | ||
| <analysisConfiguration> | ||
| <revapi.ignore> |
There was a problem hiding this comment.
Do we need ignores for a new module?
| </dependency> | ||
| <dependency> | ||
| <groupId>com.google.code.findbugs</groupId> | ||
| <artifactId>jsr305</artifactId> |
There was a problem hiding this comment.
This and error_prone_annotations below -- not used in the current client code, if I read it correctly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new concord client impl (client2):
This PR is just to release Concord with the new client. After that, we'll build concord-testcontainers with the new Concord version and in additional PR we will fully switch to client2 in Concord.