-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuration such as error messages and character sets #11
Comments
I like both of these suggestions, I think step # 1 is the change the API to programmatically list the character sets used, like you mentioned. Maybe that's just a new exported function? I also like the idea of allowing the user to specify sets of characters... Maybe we make a new struct type that holds the sets, and the ones listed in the readme are the "DefaultSets" or something |
What I was sort of thinking of is automatically determining what character set(s) the user is using based on the Unicode blocks that contain the given characters. To outline the whole idea I had:
The code would then automagically determine what Unicode blocks the user is using with their password which would allow your entropy calculation algorithm to remain practically the same (there may need to be some weighting for larger blocks such as Japan and Chinese) As for the errors, you could provide a set of messages in the config struct (noted under point two a bit earlier) or you could have a predefined set of errors (such as I'll do some fiddling around the idea when I find some time; I think this could be a fun little thing to mess around with. |
Is your feature request related to a problem? Please describe.
I was looking around if we have any go packages to handle password strength validation and I stumbled upon this.
I do like the idea behind this and I have a few suggestions that may come in handy:
Describe the solution you'd like
My first point should be straightforward on how it could be implemented; something in the lines of returning a struct which outlines the boolean flags used internally (
hasReplace
,hasLower
, ...).For the second one, I am quite unsure on how (if even possible) to implement as changes to the character sets would affect the entropy and what level would be considered secure (the table in your README).
Is this something you would consider your package to support?
With your insight and if we decide to use this approach for Corteza, I can assist with the implementation.
The text was updated successfully, but these errors were encountered: