Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner layout questions and coding issues #98

Open
jongund opened this issue May 3, 2022 · 1 comment
Open

Banner layout questions and coding issues #98

jongund opened this issue May 3, 2022 · 1 comment

Comments

@jongund
Copy link

jongund commented May 3, 2022

BannerLayout

  1. It is unusual for the W3C WAI logo to be to the right, I typical web page layout would have this left justified, is there a reason to break this web convention?
  2. The tag line "For developers of evaluation tools and test methodologies" being visually inline with the logo and title of the page is also unusual and I have to think about how it is related to the title and logo. The banner to me seems visually more complicated tag it needs to be with so many sections of text separated by horizontal bars.

Coding Issues

If the current banner layout design is going to be implemented, it is important to distinguish the "WCAG 2 Test Rules" title from the tag line "For developers of evaluation tools and test methodologies" for users of screen readers. Right now they are coded as DIV elements so screenreader ready them as a continuous line. I suggest making the "WCAG 2 Test Rules" a link and changing the markup for "For developers of evaluation tools and test methodologies" to use a P element. Screen reader will then not read them as one continuous stretch of content and also the link would be always available to take people back to the home page.

@mcking65
Copy link

mcking65 commented May 4, 2022

Thank you @jongund for the suggestion to use link and paragraph for title and tagline. That would definitely solve the screen reader problem and do so without having to use a semantic heading for the title. It is only kinda, sorta a heading ... so I hesitate to suggest heading. It would not add real value as a heading, but link does add actual value.

This should probably be solved by fixing w3c/wai-minimal-header-design#96.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants