Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline @context in examples #86

Open
filip26 opened this issue Nov 28, 2024 · 2 comments
Open

Inline @context in examples #86

filip26 opened this issue Nov 28, 2024 · 2 comments
Labels
CR1 editorial The item is editorial in nature.

Comments

@filip26
Copy link

filip26 commented Nov 28, 2024

Hi,
examples related to selective disclosure contain inline @context.

{
  "type": "DataIntegrityProof",
  "cryptosuite": "ecdsa-sd-2023",
  "created": "2023-08-15T23:36:38Z",
  "verificationMethod": "did:key:zDnaepBuvsQ8cpsWrVKw8fbpGpvPeNSjVPTWoq6cRqaYzBKVP#zDnaepBuvsQ8cpsWrVKw8fbpGpvPeNSjVPTWoq6cRqaYzBKVP",
  "proofPurpose": "assertionMethod",
  "@context": [
    "https://www.w3.org/ns/credentials/v2",
    {
      "@vocab": "https://windsurf.grotto-networking.com/selective#"
    }
  ]
}

Please see this discussion
w3c/vc-data-integrity#272

@vocab should not be used in a production. Having it in examples, test vectors, could lead to confusion and security issues.

(BTW an inline @context should be banned, it only adds complexity to processing that is vulnerable to issues, nothing else)

@msporny
Copy link
Member

msporny commented Dec 8, 2024

@vocab should not be used in a production. Having it in examples, test vectors, could lead to confusion and security issues.

Yes, agreed.

(BTW an inline @context should be banned, it only adds complexity to processing that is vulnerable to issues, nothing else)

Yes, agreed, it's unfortunate the tests include inline contexts.

We should try to remove these if possible from the test vectors and the test suites. That said, we also don't want to destabilize implementations.

/cc @BigBlueHat @PatStLouis @Wind4Greg -- what's the plan here? I suggest we switch to a driver's license, or PRC/EAD/NatCert example.

@msporny msporny added editorial The item is editorial in nature. CR1 labels Dec 8, 2024
@filip26
Copy link
Author

filip26 commented Dec 9, 2024

another option could be https://www.w3.org/ns/credentials/examples/v2. It's consistent with other VCDM2.0 based specs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR1 editorial The item is editorial in nature.
Projects
None yet
Development

No branches or pull requests

2 participants