-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review whether key
, code
etc should be present in legacy keypress
events
#349
Comments
@garykac Any thoughts on this topic? Do you recall why these fields were specified on the legacy event in the first place? |
I don't remember the details, but when we added
To hedge against this uncertainty, having defined However, I don't think we ever had a serious discussion about whether we should purposefully leave these attribute unset in the KeyboardEvent for |
Thanks @garykac - unfortunately as has been discussed earlier, it doesn't make sense to leave the Whether it makes sense to set |
Additionally, it's already spent a while after shipping the new |
@masayuki-nakano your observation re the distinction between |
I'm not sure. Basically,
I think that there should be new attribute instead of making On the other hand, some text input on macOS and Linux is represented only with |
At present the spec (see https://www.w3.org/TR/uievents/#event-type-keypress) lists
key
,code
,location
, as present and set to non-trivial values inkeypress
events.Since
keypress
events describe character-input resulting from keyboard activity (i.e.keydown
andkeyup
), and since the event is deprecated byinput
for this purpose, it's not clear why it should have non-trivial values set for these newer fields.The text was updated successfully, but these errors were encountered: