-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
underscore vs. dash #462
Comments
When you state, "or if there is any potential for a harmonization of these." It sounds like your developers would like to use one or the other in all places, right? What is the advantage or disadvantages of that? It seems that the variables using an underscore and the IDs using a dash is a feature; it makes it easier to differentiate. Not doing coding, I would just like to know. |
One issue with hyphens in the json keys is that they aren't legal in javascript identifiers. For example, you couldn't reference It's not the end of the world, as you can still use brackets to escape the key: If you use underscores in the json, though, there wouldn't be an issue: |
Our main concern here is consistency with the drafts. A good example can be seen here https://w3c.github.io/publ-a11y/a11y-meta-display-guide/2.0/techniques/epub-metadata/#understanding-the-variables-5 If we look at the variable |
Does the JSON file need to be regenerated from the techniques and guidelines? Will that resolve inconsistencies? |
This is correct because they are two different things:
I would keep the two divided, because not all variables have 1:1 correspondence with a string to be shown. For example, we have both the variable |
That makes sense that one is attributed to the id of a string and the other refers to the variable, the closeness in similarity still might be confusing. When it comes to the example you provided, I have a question:
I would expect the variable
If both are false or not present, the draft leads me to believe that a warning should be shown that flashing hazards may exist. |
That's right, the logic by which variables are parsed to generate an output is in the algorithm section: https://w3c.github.io/publ-a11y/a11y-meta-display-guide/2.0/techniques/epub-metadata/#instructions-5 |
The technique documents use an underscore to separate words in a variable, but a dash to separate words in an ID (which is how they are in https://github.com/w3c/publ-a11y/blob/main/a11y-meta-display-guide/2.0/draft/localizations/en-US/display_guide_vocabulary_w3c_en-US.json)
My developers want to understand if this is a final decision, or if there is any potential for a harmonization of these.
The text was updated successfully, but these errors were encountered: