-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-contain-1] Pubrules issues with the 2020 Rec text #5807
Comments
Oh, I just noticed that the "proposed correction" link in the mandated text is a broken fragment, while https://www.w3.org/2020/Process-20200915/#candidate-correction resolves correctly. I'm guessing the Process Document changed the term and the checker was written based on an earlier draft. The perils of bikeshedding which breaks early implementations! |
I believe your document should not contain a link to an errata page, w3c/specberus#1076 . The pubrules got confused and believed your document contained proposed corrections while it only contains candidate corrections (the CSS classes got modified recently), w3c/specberus#1077 . |
actually, the link should be |
https://www.w3.org/2020/Process-20200915/#errata
Thus, errata must indeed be maintained, but the WG now has a choice about how to do so, and inline in the spec is an acceptable way of doing it.
Agreed. the process now recognizes both candidate and proposed corrections (as different stages of the same thing), and the checker should allow both.
Indeed it doesn't. I'll let the team figure out precisely what wording you want to allow and how you want to check for it, but the Process is not the constraining factor here. |
CSS 2020 was accepted for publication, and PLH said no changes are needed, so I believe we are all good and the checker errors will be fixed. |
@frivoal @deniak @plehegar
The checker complains as follows:
The checker is correct here. All W3C Recommendations must have an errata link, which is a blank document when first published. I can make one, so this is an easy fix, although @tabatkins the CSS WG Rec boilerplate should be corrected to include this paragraph so it doesn't have to be added manually to the generated output each time.Unless there is a choice of either errata or candidate corrections, in which case the checker needs to be updated. Process Document seems to treat these as equivalent:
I suspect the checker is misled by not finding the exact paragraph "This document was published by the @@ Working Group as a Recommendation. It includes proposed corrections" which is why it asks for the separate paragraph to be removed.
I think the checker is wrong, because the process document uses the term candidate corrections, as does the 2020 Rec text for Contain 1, while the checker seems to want proposed corrections. Thus, I believe the checker is wrong and should be updated to match the term used in the Process Document.
Note that, except for existing Recommendations, the checker wants a duplicate paragraph. This should also be corrected.
Besides the insistence on the term proposed corrections as noted above, the checker wants the "This document was published " paragraph to also have the corrections note.
That is an easy fix to do, but rather buries the lede, and personally I prefer the way @frivoal did it with a separate paragraph that is styled the same as the corrections themselves.
I'm fairly sure that the precise form of wording that the checker asks for is not mandated by the Process Document, particularly since it contains grammatical errors both in the explanation and the checker-mandated paragraphs. These should be corrected, for example
or, even better
The text was updated successfully, but these errors were encountered: