-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vyos_config] Remove statements not in config #179
Comments
lucaelin
added a commit
to lucaelin/vyos.vyos
that referenced
this issue
Jul 28, 2021
lucaelin
added a commit
to lucaelin/vyos.vyos
that referenced
this issue
Jul 28, 2021
lucaelin
added a commit
to lucaelin/vyos.vyos
that referenced
this issue
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
SUMMARY
When providing config in brace style it's translated to only 'set' statements. It's then just merged with existing config, but statements not in provided config are not deleted.
It could be good to have option to load fresh full config and delete everything else. Just like Vyos 'load' command do.
Maybe something like 'state: merge [default] or replaced' as can be found in other modules?
ISSUE TYPE
COMPONENT NAME
vyos_config
ADDITIONAL INFORMATION
We build full config using templates, then send to device to replace old config with new one. Right now we just copy this config and issue 'load' command, but using proper module with diff and report what was really send to device would be definitely more proper way of doing this.
The text was updated successfully, but these errors were encountered: