Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report][3.7.1] Regression: can no longer generate declarations #20480

Open
bkuster opened this issue Sep 16, 2024 · 1 comment · May be fixed by #20484
Open

[Bug Report][3.7.1] Regression: can no longer generate declarations #20480

bkuster opened this issue Sep 16, 2024 · 1 comment · May be fixed by #20484
Assignees
Labels
T: bug Functionality that does not work as intended/expected typescript

Comments

@bkuster
Copy link

bkuster commented Sep 16, 2024

Environment

Vuetify Version: 3.7.1
Last working version: 3.7.1
Vue Version: 3.5.6

Steps to reproduce

  1. clone repo
  2. run npx vue-tsc --noEmit

Expected Behavior

This should not fail and used to work in vue ~3.4.0

Actual Behavior

This fails with: Default export of the module has or is using private name 'FilterPropsOptions'. and Default export of the module has or is using private name 'ThemeInstance'

Reproduction Link

https://github.com/bkuster/vuetify-typedeclaration

Other comments

In a way larger project, we require the use of declarations. Furthermore, do to deployment schemes, we do not use the unplugin-vue-components/vite in our vite configuraion, and thus require an import of the veutify components.

If used with defineComponents syntax, which almost all of our code base is, this will throw the above mentionend TS error as of vue ^3.5.0. This seems to work as expected using a setup script.

This may be related to this: vuejs/language-tools#1232?

@segevfiner
Copy link

I hit this with something as simple as just using VForm on the type of the the submit event callback, it seems that we have an un-exported SubmitEventPromise in vuetify/lib/components/index.d.mts, and an exported one in vuetify, which is indeed wrong and is what causing this error. This is likely coupled with some change in the Vue template compiler that was done at some point which then triggers this error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: bug Functionality that does not work as intended/expected typescript
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants