Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export NavigationDuplicated class #3039

Closed
LEW21 opened this issue Nov 26, 2019 · 3 comments
Closed

Export NavigationDuplicated class #3039

LEW21 opened this issue Nov 26, 2019 · 3 comments

Comments

@LEW21
Copy link

LEW21 commented Nov 26, 2019

What problem does this feature solve?

I want to do:

try {
	await router.push(...)
} catch (e) {
	if (e instanceof NavigationDuplicated) {}
	else {throw e}
}

Unfortunately I can't, because NavigationDuplicated is not exported.

What does the proposed API look like?

export NavigationDuplicated

@FranckFreiburger
Copy link

Please export this, it is quite annoying to compare to the error name.

@jonatahr
Copy link

jonatahr commented Jan 8, 2020

@LEW21 and @FranckFreiburger, take a look:
#3047

You will be able to check the error type by property _type. This information must be documented.

@posva
Copy link
Member

posva commented Mar 18, 2020

I'm closing this in favour of #3047

It's not final API as we want to align it with vue-router-next as much as possible to reduce breaking changes. It will probably be available through an additional property on the error instance to support every browser

@posva posva closed this as completed Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants