-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhanceApp()
ctx.router
is not a router instance
#4204
Labels
docs
Improvements or additions to documentation
Comments
Ah, it's router, but that function is not exactly a hook. You need to define it - #2564 (comment) router.onBeforeRouteChange = (to) => {
console.log('onBeforeRouteChange', to)
} |
brc-dd
added
docs
Improvements or additions to documentation
and removed
bug: pending triage
Maybe a bug, waiting for confirmation
labels
Sep 16, 2024
Aha! Yes, I think defo a docs issue. Thanks for coming back so very quickly!!! 🥰 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The theme docs and code completion state that the
router
instance is exposed inenhanceApp()
but it appears therouter
instance is actually aroute
instance, and doesn't conform to the Router interface.Reproduction
Initialize a new project, then add the following code to
enhanceApp()
:Expected behavior
We should be able to interact with the
router
instanceSystem Info
Additional context
No response
Validations
The text was updated successfully, but these errors were encountered: