Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devtools): setup the settings panel immediately #2858

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from

Conversation

noootwo
Copy link
Contributor

@noootwo noootwo commented Dec 13, 2024

fix #2818

Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for pinia-playground ready!

Name Link
🔨 Latest commit 89ac583
🔍 Latest deploy log https://app.netlify.com/sites/pinia-playground/deploys/675c1607b5b2ce0008a9f189
😎 Deploy Preview https://deploy-preview-2858--pinia-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for pinia-official canceled.

Name Link
🔨 Latest commit 89ac583
🔍 Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/675c1607214e220008460c00

Copy link

pkg-pr-new bot commented Dec 13, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@pinia/nuxt@2858
npm i https://pkg.pr.new/pinia@2858
npm i https://pkg.pr.new/@pinia/testing@2858

commit: 89ac583

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.75%. Comparing base (4715104) to head (89ac583).
Report is 10 commits behind head on v2.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #2858      +/-   ##
==========================================
+ Coverage   88.45%   88.75%   +0.29%     
==========================================
  Files          19       19              
  Lines        1447     1449       +2     
  Branches      228      226       -2     
==========================================
+ Hits         1280     1286       +6     
+ Misses        166      162       -4     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pinia devtools will not call setupDevtoolsPlugin until useStore is called
1 participant