Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: maximum call stack #605

Open
reslear opened this issue Sep 9, 2024 · 12 comments
Open

bug: maximum call stack #605

reslear opened this issue Sep 9, 2024 · 12 comments
Labels
need reproduction Reproduction is needed

Comments

@reslear
Copy link
Contributor

reslear commented Sep 9, 2024

CleanShot 2024-09-09 at 17 36 55@2x

could be due to async persistedstate: https://github.com/soc221b/pinia-plugin-persistedstate-2

vue 5.5.3
devtools latest

@twisterniq
Copy link

twisterniq commented Sep 11, 2024

I'm having the same issue but couldn't create a minimal reproduction. However, I’ve noticed a few things:

  • The issue starts with Vue version 3.5.0 and persists through 3.5.4.
  • It doesn't occur in version 3.4.38.
  • The console spam begins after I open the Vue tab in Developer Tools.
  • If I open a new tab and do not click on the Vue tab, there’s no spam.
  • It is definitely related to Pinia.

@webfansplz
Copy link
Member

I'm having the same issue but couldn't create a minimal reproduction. However, I’ve noticed a few things:

  • The issue starts with Vue version 3.5.0 and persists through 3.5.4.
  • It doesn't occur in version 3.4.38.
  • The console spam begins after I open the Vue tab in Developer Tools.
  • If I open a new tab and do not click on the Vue tab, there’s no spam.
  • It is definitely related to Pinia.

Thanks for the feedback, could you also use https://github.com/soc221b/pinia-plugin-persistedstate-2?

@webfansplz
Copy link
Member

CleanShot 2024-09-09 at 17 36 55@2x

could be due to async persistedstate: https://github.com/soc221b/pinia-plugin-persistedstate-2

vue 5.5.3 devtools latest

I can not reproduce it, can you provide a mini repo? thanks.

@twisterniq
Copy link

I'm having the same issue but couldn't create a minimal reproduction. However, I’ve noticed a few things:

  • The issue starts with Vue version 3.5.0 and persists through 3.5.4.
  • It doesn't occur in version 3.4.38.
  • The console spam begins after I open the Vue tab in Developer Tools.
  • If I open a new tab and do not click on the Vue tab, there’s no spam.
  • It is definitely related to Pinia.

Thanks for the feedback, could you also use https://github.com/soc221b/pinia-plugin-persistedstate-2?

I'm using https://github.com/prazdevs/pinia-plugin-persistedstate, but I tested without it as well, and the issue still persists.

@webfansplz
Copy link
Member

I'm having the same issue but couldn't create a minimal reproduction. However, I’ve noticed a few things:

  • The issue starts with Vue version 3.5.0 and persists through 3.5.4.
  • It doesn't occur in version 3.4.38.
  • The console spam begins after I open the Vue tab in Developer Tools.
  • If I open a new tab and do not click on the Vue tab, there’s no spam.
  • It is definitely related to Pinia.

Thanks for the feedback, could you also use https://github.com/soc221b/pinia-plugin-persistedstate-2?

I'm using https://github.com/prazdevs/pinia-plugin-persistedstate, but I tested without it as well, and the issue still persists.

Can you provide a mini repo? Thanks 🙏.

@JeanFranz73
Copy link

having the same issue on a work project, without pinia-plugin-persistedstate plugin, can't show the code but trying to reproduce in a clean installation
image

@webfansplz webfansplz added the need reproduction Reproduction is needed label Sep 12, 2024
@webfansplz
Copy link
Member

I'm not sure if it related to vue, can someone upgrade to vue 3.5.5 and try again?

@twisterniq
Copy link

I'm not sure if it related to vue, can someone upgrade to vue 3.5.5 and try again?

I´ve just tried it and the issue is still happening.

@webfansplz
Copy link
Member

I'm not sure if it related to vue, can someone upgrade to vue 3.5.5 and try again?

I´ve just tried it and the issue is still happening.

Can you help to provide a mini repo? 🙏

@reslear
Copy link
Contributor Author

reslear commented Sep 16, 2024

@twisterniq @JeanFranz73
It’s strange that there’s no such issue in the minimal reproduction.

Could someone fork it and add some details closer to your product?

https://stackblitz.com/edit/vitejs-vite-uiu4uu?file=src%2Fcomponents%2FHelloWorld.vue

@twisterniq
Copy link

I tried to create a minimal reproduction, but at this point I still don't know what exactly is causing the issue. I'll try to do some more tests when I have more time.

@eneeio-nm
Copy link

eneeio-nm commented Sep 16, 2024

I'm getting the same - and I'm using the Beta version of the Chrome Extension:

screenshot-2024-09-16--15 42 49@2x

I don't have pinia-plugin-persistedstate. I do use pinia and also TanStack Query Devtools.

Other packages include:

    "pinia": "2.2.2",
    "primevue": "4.0.7",
    "vue": "3.5.6",
    "vue-i18n": "10.0.1",
    "vue-router": "4.4.5"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need reproduction Reproduction is needed
Projects
None yet
Development

No branches or pull requests

5 participants