Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor in sfc-playground #4683

Closed
phantomlsh opened this issue Sep 27, 2021 · 2 comments
Closed

Editor in sfc-playground #4683

phantomlsh opened this issue Sep 27, 2021 · 2 comments

Comments

@phantomlsh
Copy link

What problem does this feature solve?

Would you consider using microsoft/monaco-editor in sfc-playground? I believe that this editor is much more powerful than the current CodeMirror, including but not limited to auto-completion and syntax checking.

What does the proposed API look like?

A monaco-editor or other equivalent in sfc-playground

@yyx990803
Copy link
Member

The concern is mostly loading speed, as Monaco is significantly larger than CodeMirror (close to 3Mb vs less than 100kb).

I think for sfc playground it probably makes sense to use Monaco, but ideally we want to provide two different versions, one optimized for editing experience (standalone playground) and one optimized for loading (embedded use cases).

Also this should be now discussed in https://github.com/vuejs/repl which is used in the SFC playground.

@phantomlsh
Copy link
Author

Would you please take a quick look at this issue? Thanks a lot!

vuejs/repl#2

@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants