Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(custom-element): fix parent resolving issue when slotted in shadow dom #12480

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(custom-element): fix parent resolving issue when slotted in shadow dom #12480

wants to merge 1 commit into from

Conversation

lejunyang
Copy link

close #12479

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 27, 2024 •
edited
Loading

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12480

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12480

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12480

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12480

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12480

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12480

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12480

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12480

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12480

vue

npm i https://pkg.pr.new/vue@12480

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12480

commit: fce4707

@github-actions GitHub Actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+16 B) 37.9 kB (+6 B) 34.2 kB (-10 B)
vue.global.prod.js 158 kB (+16 B) 57.8 kB (+8 B) 51.5 kB (+31 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.2 kB 18.3 kB 16.8 kB
createApp 55.2 kB 21.3 kB 19.5 kB
createSSRApp 59.3 kB 23.1 kB 21 kB
defineCustomElement 60.1 kB (+18 B) 22.9 kB (+10 B) 20.9 kB (+6 B)
overall 69.1 kB 26.5 kB 24.1 kB

@lejunyang lejunyang force-pushed the parent-resolving-fix branch from 0ced694 to fce4707 Compare November 27, 2024 13:19
@edison1105 edison1105 added ready to merge The PR is ready to be merged. 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. scope: custom elements labels Nov 27, 2024
@edison1105
Copy link
Member

Great work.

@edison1105 edison1105 requested a review from Copilot November 27, 2024 13:28
Copilot
Copilot AI reviewed Nov 27, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no suggestions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged. scope: custom elements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discrepancy in parent resolving for vue custom element and vue component
2 participants
@lejunyang @edison1105