Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reactivity): avoid exponential perf cost and reduce call stack depth for deeply chained computeds #11944

Merged
merged 3 commits into from
Sep 16, 2024

Conversation

yyx990803
Copy link
Member

close #11928

@yyx990803 yyx990803 merged commit c74bb8c into main Sep 16, 2024
14 of 15 checks passed
@yyx990803 yyx990803 deleted the reactivity-fix branch September 16, 2024 08:00
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 37.9 kB 34.1 kB
vue.global.prod.js 159 kB 57.8 kB 51.3 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 48.8 kB 18.8 kB 17.2 kB
createApp 55.4 kB 21.3 kB 19.4 kB
createSSRApp 59.4 kB 23 kB 20.9 kB
defineCustomElement 60.2 kB 22.9 kB 20.8 kB
overall 69.1 kB 26.4 kB 24 kB

Copy link

pkg-pr-new bot commented Sep 16, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11944

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11944

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11944

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11944

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11944

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11944

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11944

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11944

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11944

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11944

vue

pnpm add https://pkg.pr.new/vue@11944

commit: d9dd0f3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential @vue/reactivity bug discovered during benchmark stress tests
1 participant