-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue 2 migration build WATCH_ARRAY triggers on deep value modification #11872
Comments
I’m not sure if this is considered a bug. It seems more like an undocumented breaking change. |
It could arguably be considered an undocumented breaking change, however it's a very impactful breaking change which has a relatively easy fix, so I'd consider it less "bug" and more "oversight." Unfortunately the migration path isn't so easy for a user updating past the migration build, so documenting it in the deprecation message might be cumbersome. (The best solutions I've come up with involve a computed property calling slice and returning either |
Vue version
3.4.38 (compat)
Link to minimal reproduction
https://stackblitz.com/edit/vitejs-vite-cpcesj?file=src%2FApp.vue
Steps to reproduce
[{foo: 0}, {foo: 1}]
) and add a watch on itarr = [...arr]
)arr.push({foo: 2})
)arr[0].foo++
)What is expected?
The watch should be triggered when the array is replaced or mutated, but should not be triggered when the contents of the array elements are modified (Vue 2 repro)
What is actually happening?
The watch is triggered in all three cases, on replacement, mutation, and deep modification
System Info
No response
Any additional comments?
The compat is implemented here in createWatcher, and it's implemented by doing a deep traversal of array values. The Vue 2 behavior can be reproduced by instead calling
array.slice(0, 0)
there, which creates a reactive dependency onTrackOpTypes.ITERATE
. The internal shallowReadArray function may also be more appropriate to call in internal code.The text was updated successfully, but these errors were encountered: