Size Report

Bundles

Usages

Why not reuse moveTeleport?

Suggestions

Implement active and deactive inside TeleportImpl, and reuse moveTeleport within these methods.

export const TeleportImpl {
    //...
	active: activeTeleport
	deactive: deactiveTeleport
}

function activeTeleport(...){
	// try reuse moveTeleport
}
function deactiveTeleport(...){
	// try reuse moveTeleport
}

in KeepAlive

// active
(vnode.type as typeof TeleportImpl).active(...)

// deactive
(vnode.type as typeof TeleportImpl).deactive(...)

Why not reuse moveTeleport?

core/packages/runtime-core/src/components/Teleport.ts

Line 306 in 8655ced

function moveTeleport(

Suggestions

Implement active and deactive inside TeleportImpl, and reuse moveTeleport within these methods.

export const TeleportImpl {
    //...
	active: activeTeleport
	deactive: deactiveTeleport
}

function activeTeleport(...){
	// try reuse moveTeleport
}
function deactiveTeleport(...){
	// try reuse moveTeleport
}

in KeepAlive

// active
(vnode.type as typeof TeleportImpl).active(...)

// deactive
(vnode.type as typeof TeleportImpl).deactive(...)

Thanks for your review, I will try to modify it.