Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to make it work with SwiftUI on macOS #114

Closed
bourquep opened this issue Dec 23, 2023 · 4 comments · Fixed by #115
Closed

Unable to make it work with SwiftUI on macOS #114

bourquep opened this issue Dec 23, 2023 · 4 comments · Fixed by #115
Labels

Comments

@bourquep
Copy link

I instantiate the view like this:

NavigationView {
  AcknowListSwiftUIView(acknowList: AcknowParser.defaultPackages()!)
}

And I get this result:

CleanShot 2023-12-23 at 10 37 08@2x

Clicking on the buttons does nothing.

@vtourraine vtourraine added the bug label Jan 8, 2024
@vtourraine
Copy link
Owner

Thank you for reporting this!

I’ll try to investigate, but feel free to submit a pull request if you manage to fix it.

@vtourraine
Copy link
Owner

@bourquep I have opened a pull request that should fix your problem: #115

Could you please test it, and confirm the links open? (I know that doesn’t improve the interface, which is quite poor at the moment on macOS with SwiftUI, but that will be a different pull request.) Thank you in advance!

@bourquep
Copy link
Author

bourquep commented Jan 9, 2024

@vtourraine I am no longer setup to test this, as I've moved to another library, but I'll give it a shot soon and get back to you!

@vtourraine
Copy link
Owner

@bourquep Thanks for the update, I’m looking forward to your feedback. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants