Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support KHR_animation_pointer extension #172

Open
issacclee opened this issue Feb 8, 2023 · 3 comments
Open

Support KHR_animation_pointer extension #172

issacclee opened this issue Feb 8, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@issacclee
Copy link

Hi,

I'm looking to implement the support for KHR_animation_pointerextension(which is close to getting ratified).

One of the major changes this extension implies is the ability to set animation.channel.target.path as "pointer". I was wondering does that mean we have to add the pointer path definition to the generated gltf.g.cs file and modify the AnimationChannelTarget class to accommodate the new target path type?

@vpenades
Copy link
Owner

vpenades commented Feb 8, 2023

Most probably yes. Another alternative is, given the path seems to be quite "open", I could consider converting it to a string, but then it would break the APIs.

@vpenades
Copy link
Owner

Looking at the extension. The extension itself its tiny, but its implications are huge across all the architecture of glTF

So it's not enough to simply add the extension. After adding it, suddenly, you have to make all the properties that can be targeted by this extension, "animation aware" .... it makes pretty much anything within the scene animatable

@issacclee
Copy link
Author

Looking at the extension. The extension itself its tiny, but its implications are huge across all the architecture of glTF

So it's not enough to simply add the extension. After adding it, suddenly, you have to make all the properties that can be targeted by this extension, "animation aware" .... it makes pretty much anything within the scene animatable

I agree, it will have huge impact on the current implementation. If you take all the necessary validation that needs to be perform into account.

@vpenades vpenades added the enhancement New feature or request label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants