Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blackbox exporter modules leaking sensitive data as it get logged as plaintext #614

Open
mvnarsing opened this issue Apr 12, 2022 · 0 comments · May be fixed by #615
Open

Blackbox exporter modules leaking sensitive data as it get logged as plaintext #614

mvnarsing opened this issue Apr 12, 2022 · 0 comments · May be fixed by #615

Comments

@mvnarsing
Copy link

mvnarsing commented Apr 12, 2022

Blackbox exporter module can contain passwords as part of basic auth, its not treating modules as sensitive value and leaking info in plaintext

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet:
  • Ruby:
  • Distribution:
  • Module version:

How to reproduce (e.g Puppet code you use)

ex_http_post_200:
    prober: http
    timeout: 10s
    http:
      valid_http_versions:
        - HTTP/1.1
        - HTTP/2.0
      follow_redirects: true
      preferred_ip_protocol: "ip4"
      method: POST
      headers:
        Content-Type: text/xml
      valid_status_codes: [200]
      body: {}
      basic_auth:
        username: "%{lookup('ex_username')}"
        password: "%{lookup('ex_password')}"

What are you seeing

password is displayed in plaintext as part of puppet runs

What behaviour did you expect instead

hash or sensitive password

Any additional information you'd like to impart

workaround we applied is to not show diff for puppet runs, submitting PR with code changes for this fix. PR

file { $config_file:
    ensure  => file,
    owner   => 'root',
    group   => $group,
    mode    => $config_mode,
    `show_diff => false,`
    content => template('prometheus/blackbox_exporter.yaml.erb'),
    notify  => $notify_service,
  }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant