Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installing from git #166

Open
onzyone opened this issue Sep 21, 2015 · 7 comments
Open

installing from git #166

onzyone opened this issue Sep 21, 2015 · 7 comments
Labels
bug Something isn't working needs-work not ready to merge just yet

Comments

@onzyone
Copy link

onzyone commented Sep 21, 2015

when installing a module from git

  nodejs::npm { 'node-wimoto':
    ensure  => 'present',
    package => 'node-wimoto',
    source  => 'onzyone/node-wimoto',
    target  => '/opt/packages',
  }

source ends up in the grep as source is no longer registry

  if $source != 'registry' {
    $install_check_package_string = $source
    $package_string = $source

this fails and re installs the module over and over again as it is looking for

Debug: Exec[npm_install_node-wimoto](provider=posix): Executing check '/usr/bin/npm ls --long --parseable | grep "/opt/packages/node_modules/onzyone/node-wimoto"'
Debug: Executing: '/usr/bin/npm ls --long --parseable | grep "/opt/packages/node_modules/onzyone/node-wimoto"'

and not

grep "/opt/packages/node_modules/node-wimoto"'
@igalic
Copy link
Contributor

igalic commented Sep 21, 2015

@onzyone do you think you can provide a patch for this?

@onzyone
Copy link
Author

onzyone commented Sep 21, 2015

Yup I am looking into it and will give one in the next few days.

On Mon, Sep 21, 2015 at 12:12 PM, Igor Galić [email protected]
wrote:

@onzyone https://github.com/onzyone do you think you can provide a
patch for this?


Reply to this email directly or view it on GitHub
#166 (comment)
.

@onzyone
Copy link
Author

onzyone commented Sep 21, 2015

have a look at this and run a few tests: https://github.com/onzyone/puppet-nodejs/tree/onzyone-patch-1 and I will do merge

@igalic
Copy link
Contributor

igalic commented Sep 22, 2015

uhm… @onzyone if you create the pull request against this repo, then travis can take care of running tests for you :)

@juniorsysadmin juniorsysadmin added the needs-work not ready to merge just yet label Nov 16, 2015
@jyaworski
Copy link
Member

What's the status of this?

@igalic
Copy link
Contributor

igalic commented Mar 9, 2016

¯\(o_°)/¯

@juniorsysadmin juniorsysadmin added the bug Something isn't working label Jun 2, 2016
@juniorsysadmin
Copy link
Member

juniorsysadmin commented Jun 2, 2016

If I recall correctly I think the bug is that the module assumes package rather than namespace/package for source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-work not ready to merge just yet
Projects
None yet
Development

No branches or pull requests

4 participants