Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No access_log for locations (and other levels) #1620

Open
ltning opened this issue Oct 28, 2024 · 0 comments
Open

No access_log for locations (and other levels) #1620

ltning opened this issue Oct 28, 2024 · 0 comments

Comments

@ltning
Copy link
Contributor

ltning commented Oct 28, 2024

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: Any
  • Ruby: Any
  • Distribution: Any
  • Module version: Any

Any additional information you'd like to impart

Currently, access_log can only be directly defined in the server scope. (Re)defining at location scope requires location_cfg_append or, in our case, raw_append.

Since we use multiple access_log statements at various levels of the configuration, this is difficult to maintain. The suggested (in resource/location.pp) way to define access_log for a location - using location_cfg_append - cannot be used since we need more than one entry. As a result, we are required to use raw_append or similar instead. This in turn leads to other problems; we cannot "inherit" the access_log statements from the server level, since those are defined as arrays.

While I'm sure there are ways around this, so we can define a common set of access_log settings in one place and re-use - for example by using raw_prepend/append also on the server level, this feels clumsy.

Support for access_log (and error_log) on all levels - http, server, location (and possibly 'if' and 'limit_except') - would be quite helpful.

Thanks for reading!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant