Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for reloading config #1619

Open
Ph0B1uS opened this issue Oct 10, 2024 · 0 comments
Open

Support for reloading config #1619

Ph0B1uS opened this issue Oct 10, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Ph0B1uS
Copy link

Ph0B1uS commented Oct 10, 2024

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 8.9.0
  • Distribution: Debian 11
  • Module version: 5.0.0 (but the issue remains in master at the time of writing)

How to reproduce (e.g Puppet code you use)

Make a config change and wait for the refresh

What are you seeing

The service is always restarted and I cannot find any way of getting it to reload instead

What behaviour did you expect instead

That there is a way to make the service reload instead of restart at config changes

Any additional information you'd like to impart

Why is this important you might ask?
Well if you make a boo boo with the config (accidentally of course) then what happens is that NGiNX will not start because it will stop, read the config and realise it's invalid or otherwise faulty and refuse to start.
A reload on the other hand will examine the config, realise that it is b0rked and just not load it meaning that you still have a service with a working config up and running.

@kenyon kenyon added the enhancement New feature or request label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants