Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default mongodb version to 7.x #754

Open
h-haaks opened this issue Apr 25, 2024 · 4 comments · May be fixed by #757
Open

Update default mongodb version to 7.x #754

h-haaks opened this issue Apr 25, 2024 · 4 comments · May be fixed by #757

Comments

@h-haaks
Copy link
Contributor

h-haaks commented Apr 25, 2024

Now that we have mongodb 7.x support and we have breaking changes already in the next release, do we bump default repo version to 7.0 as well?

@h-haaks
Copy link
Contributor Author

h-haaks commented Apr 25, 2024

@stevenpost @witjoh any thoughts on this? Bumping the default version would be a breaking change as well.

@h-haaks
Copy link
Contributor Author

h-haaks commented Apr 26, 2024

Debian 10 support ends at 6.0

@h-haaks h-haaks linked a pull request Apr 26, 2024 that will close this issue
@stevenpost
Copy link
Contributor

Now that we have mongodb 7.x support and we have breaking changes already in the next release, do we bump default repo version to 7.0 as well?

Might as well, but if Debian 10 is still supported and only goes till 6.0 it may make sense to default to 6.0 instead of 7. Just so the defaults for every OS are the same, principle of least surprise.
I don't have a strong opinion on it, so 7.0 is fine with me as well. In that case you may want to remove Debian 10 altogether, LTS support ends June 30th, 2024.

@h-haaks
Copy link
Contributor Author

h-haaks commented Apr 27, 2024

Hmm, I wonder if we should implement the repo install more like package do it.
I mean write a fact for repo_version and use repo_ensure => present/absent/ in the repo class.

If present on first run install latest supported.
If version and version != fact update repo def.

The code as it is right now will just add a new repo side by side the old repo if the version is changed ...
Further updating the repo version will not upgrade mongodb server or client ..
The actual upgrade of mongodb will happen if someone later run apt/yum/dnf update/upgrade on the server.

I think we are better off not merging #757 yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants