Possible performance improvement for multiple plugin checks

[ogtool]

In our environment we're using 3 logstash plugins (geoip, useragent and urldecode) and when doing a puppet agent run with --debug it indicates slowness when these add-ons are being checked.

For each add-on, it runs "/usr/share/logstash/bin/logstash-plugin list ^addonname$" - which when run from a command line takes 5-10 seconds. The same command then runs again for each add-on.

Given you can pass in a regex, you can check if all of the plugins are available with the syntax /usr/share/logstash/bin/logstash-plugin list '^(addonA|addonB|addonC)$' - which only takes the same amount of time as running a check for each plugin in the list.

If the output from this single command could be parsed appropriately, then run time wouldn't increase with each new plugin used.

[fatmcgav]

@ogtool Cheers for reporting this issue.

I think the best approach for this would be to create a logstash-plugin resource which can be used, rather than relying on an exec resource.

I'll stick it on the todo list :)

[shazi7804]

follow up