Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The logrotate package should be 'present' by default, or at least tunable #11

Closed
natemccurdy opened this issue Nov 4, 2015 · 3 comments
Closed

The logrotate package should be 'present' by default, or at least tunable #11

natemccurdy opened this issue Nov 4, 2015 · 3 comments

Comments

@natemccurdy
Copy link

This issue is the same issue from rodjek's original project, rodjek#58. I'm just pulling it into yo61's fork because I agree with the original issue.

There is a PR that proposed a fix at rodjek#59

Currently the package's state is not a class parameter in logrotate::base and its default value of 'latest' doesn't seem to be justified.

If ever YUM is used by another user/process at the same time as a Puppet run or if the repositories are too slow to answer, that shows up as a failure in the run.
@robinbowes
Copy link

I think I've refactored since that issue/PR was created. There is no longer a logroate::base class, and the logrotate class has an "ensure" parameter.

Can you check that meets your requirements?

R.

@natemccurdy
Copy link
Author

Hi @robinbowes . Ah, you're right, there is an ensure parameter. Sorry, I must've just assumed there wasn't one when I saw that the package was trying to be upgraded.

However, I am of the mindset that it is best to default packages to "installed" or "present". That way the end-user can choose when to upgrade if needed.

@robinbowes
Copy link

I wouldn't disagree with that. PR welcome ;)

natemccurdy added a commit to natemccurdy/puppet-logrotate that referenced this issue Nov 4, 2015
@natemccurdy
Default to ensure => 'installed' for the package
c2cd26e 
Prior to this, the default value for the `ensure` parameter of the
logrotate package was set to 'latest'. This meant that by simply
declaring a logrotate::rule, the package could also be updated. It is
generally not a good idea to update system packages unless being done in
a controlled envrionment.

To fix that issue, the default value is being changed to 'intalled'.
This way, the end-user can choose to update the logrotate package when
they want to.

This fixes issue voxpupuli#11
@natemccurdy natemccurdy mentioned this issue Nov 4, 2015
Merged
natemccurdy added a commit to natemccurdy/puppet-logrotate that referenced this issue Nov 4, 2015
@natemccurdy
Default to ensure => 'present' for the package
f4b0db2 
Prior to this, the default value for the `ensure` parameter of the
logrotate package was set to 'latest'. This meant that by simply
declaring a logrotate::rule, the package could also be updated. It is
generally not a good idea to update system packages unless being done in
a controlled envrionment.

To fix that issue, the default value is being changed to 'present'.
This way, the end-user can choose to update the logrotate package when
they want to.

This fixes issue voxpupuli#11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@robinbowes @natemccurdy