collectd::ci_package_repo = 'master' builds wrong yum repo URL

[andylytical]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 4.8.2
• Ruby: 2.1.9
• Distribution: CentOS Linux release 7.3.1611 (Core)
• Module version: puppet-collectd (v5.3.0)

How to reproduce (e.g Puppet code you use)

Set collectd::ci_package_repo: 'master' in hiera or in collectd puppet declaration.

What are you seeing

Error: /Stage[main]/Collectd::Plugin::Disk/Package[collectd-disk]/ensure: change from purged to present failed: Execution of '/usr/bin/yum -d 0 -e 0 -y install collectd-disk' returned 1: One of the configured repositories failed (collectd-ci), and yum doesn't have enough cached data to continue. At this point the only safe thing yum can do is fail.
failure: repodata/repomd.xml from collectd-ci: [Errno 256] No more mirrors to try.
https://pkg.ci.collectd.org/rpm/collectd-master/epel-7-x86_64/repodata/repomd.xml: [Errno 14] HTTPS Error 404 - Not Found

What behaviour did you expect instead

Expected the collectd-disk package to be installed from the collectd-ci repo.

Notice: /Stage[main]/Collectd::Repo::Redhat/Yumrepo[collectd-ci]/baseurl: baseurl changed 'https://pkg.ci.collectd.org/rpm/collectd-master/epel-7-x86_64' to 'https://pkg.ci.collectd.org/rpm/collectd-5.7/epel-7-x86_64'
Notice: /Stage[main]/Collectd::Plugin::Disk/Package[collectd-disk]/ensure: created

Output log

Any additional information you'd like to impart

Appears that the collectd-ci repo URL creation incorrectly prefixes <collectd-ci-branch> with the string colletd-, which is not a valid action when setting collectd::ci_package_repo = 'master'. The correct URL appears to be: https://pkg.ci.collectd.org/rpm/master/epel-7-x86_64 (NOTE: master is not prefixed with collectd-).