Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collectd::plugin::rabbitmq manifest - Should have a OS test override option #1018

Open
ArcticSnowman opened this issue Apr 18, 2023 · 0 comments

Comments

@ArcticSnowman
Copy link

ArcticSnowman commented Apr 18, 2023

The current collectd::plugin::rabbitmq manifest https://github.com/voxpupuli/puppet-collectd/blob/master/manifests/plugin/rabbitmq.pp - will not allow the plugin to be install on newer OS, as it assumes that Python3 is the default.

There is no ability to bypass this OS version check, even when a host was Python2 as the default .

Please add the ability to bypass this check so that the plugin can be installed.

if $facts['os']['family'] == 'Debian' and versioncmp($facts['os']['release']['major'], '11') >= 0 or
  $facts['os']['family'] == 'RedHat' and versioncmp($facts['os']['release']['major'], '8') >= 0 or
  $facts['os']['name'] == 'Ubuntu' and versioncmp($facts['os']['release']['major'], '20.04') >= 0 {
    fail('https://pypi.org/project/collectd-rabbitmq/ does not support Python 3')
  }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant