Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made Player a character, introduce NonPlayerCharacter for executing tasks #619

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Made Player a character, introduce NonPlayerCharacter for executing tasks #619

wants to merge 5 commits into from

Conversation

mrzzzrm
Copy link

@mrzzzrm mrzzzrm commented May 29, 2014

Fixes #617

Also introduces the possibility for Characters to have a nullptr-Faction. There is no semantic sense in uniting all "free" characters into one Faction, as they don't share reputation.

PS: A small sign of life from my side. The sectors are coming and they're gonna be big! Also, BPs drain life....

@gersseba
Copy link
Contributor

gersseba commented Jun 1, 2014

damn it, how could I not see your pr? well that sucks for me...
I think not all is lost though, besides making the player a character I also added a PlayerBoardComputer and orderpriorities. Both combined allow the player to take part in formation and tasks, but still be able to override these with keyboard input

@gersseba
Copy link
Contributor

gersseba commented Jun 1, 2014

Also this eliminates the need for an npcharacter as the player is also able to perform tasks

@gersseba
Copy link
Contributor

gersseba commented Jun 1, 2014

Maybe we can leave this pr and my branch on hold until next week and meet up to discuss whether we can use some of my branch as well

@mrzzzrm
Copy link
Author

mrzzzrm commented Jun 1, 2014

Won't have time for a meeting next week, but the week after would be fine. We can put this on hold until then. I'll try to look into your branch in the meantime.

@gersseba
Copy link
Contributor

gersseba commented Jun 1, 2014

OK, have fun, select a formation member and press 'o' to join

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Player is a Character
2 participants
@mrzzzrm @gersseba