Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting queue.spec.capacity.cpu field empty in child queue will result in an error: Failed to check queue's hierarchical structure #3914

Open
yccharles opened this issue Dec 23, 2024 · 3 comments · May be fixed by #3917
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@yccharles
Copy link

Description

  1. build hierarchical queue like this: root's child queue is root-sub1. root-sub1's child queue is root-sub1-sub1
root 
 |
root-sub1 ( capacity.cpu = 100,  mem=10Gi)
 |
root-sub1-sub1 ( capacity.mem = 5Gi)
  1. create vcjob with queue = root-sub1-sub1 .

we can see error log in vc-scheduler : Failed to check queue's hierarchical structure, error.....
image

Steps to reproduce the issue

  1. create an queeu with queue.spec.capacity.cpu field empty .
  2. create a vcjob .

Describe the results you received and expected

Because of there is a default values when cpu/mem is null . Cpu would be setting to MaxFloat64.

attr.capability.MilliCPU = math.MaxFloat64

So, should we reject creation a queue in admission-webhook when queue.spec.capacity.cpu/mem is null ?

What version of Volcano are you using?

master

Any other relevant information

No response

@yccharles yccharles added the kind/bug Categorizes issue or PR as related to a bug. label Dec 23, 2024
@JesseStutler
Copy link
Member

Thank you very much for discovering these problems before our version is released. The hierarchical queue has just been developed and there may indeed be some bugs. We still need to continue iterating. Do you have any requirements for using the hierarchical queue?

@JesseStutler
Copy link
Member

Actually the capability setting is this line if capability is nil:

attr.capability.MilliCPU = math.MaxFloat64

@JesseStutler
Copy link
Member

@Monokaix We need to also carry this issue into v2.0 milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
2 participants