Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polling shard consumer directly uses logrus #52

Open
brandon-lango opened this issue Jan 9, 2024 · 0 comments
Open

polling shard consumer directly uses logrus #52

brandon-lango opened this issue Jan 9, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@brandon-lango
Copy link

Describe the bug

The polling shard consumer includes logrus and directly uses it in the renewLease function. It should be using the logger passed in kclconfig like the other functions.

Reproduction steps

Start a working using the polling consumer. Notice the debug level refreshing lease on shared messages coming from logrus.

Expected behavior

All log messages use the logger I have configured in kclconfig.

Additional context

Log is spammed with debug level messages with "Refreshing lease on shard:". To work around this, the logrus level needs to be set.

@brandon-lango brandon-lango added the bug Something isn't working label Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant