Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore finalizing should not run if the async restore operation is failed/cancelled #8182

Open
Lyndon-Li opened this issue Sep 4, 2024 · 1 comment

Comments

@Lyndon-Li
Copy link
Contributor

Lyndon-Li commented Sep 4, 2024

Related to #8178.

We have a finalizing operation after the async restore completes regardless of the completion status of the async restore. At present, this finalizing operation is used to patch the restored PV, there are some problems:

  1. If the async operation was not successful, the PV patching operation may never succeed since the PVC/PV may not have been successfully restored
  2. If we run the finalizing operation for failed/cancelled aysnc operation, we need to be careful that the errors/warnings generated by the async operation may be overwritten by the finalizing operation

Therefore, for the current PV patch task, it should not run for failed/cancelled async operations; and for a general purpose, we need to consider whether allow the finalizing operation to run for failed/cancelled async operations.

@reasonerjt
Copy link
Contributor

I recall there was an issue with same problem. I'll try to find out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants