feat: make backoffLimit configurable for Helm jobs #723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add configurable backoffLimit for upgrade-crds, cleanup-crds, and label-namespace jobs. Defaults to 3 to maintain backward compatibility. This allows users to increase the retry limit for jobs that may fail due to transient issues like image pull delays, network latency, or resource constraints. Fixes: vmware-tanzu/helm-charts#<issue-number> (if applicable) Configuration: - upgradeCRDsJob.backoffLimit: Controls retries for the pre-install/upgrade CRD job - cleanUpCRDsJob.backoffLimit: Controls retries for the pre-delete CRD cleanup job - labelNamespaceJob.backoffLimit: Controls retries for the namespace labeling job Signed-off-by: Cursor AI Assistant <[email protected]>
Collaborator
|
@fabioaraujopt please help bump chart version, thank you. |
Author
fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the
backoffLimitconfigurable for Velero's Helm job resources, allowing users to adjust retry limits based on their environment needs.Motivation
The current hardcoded
backoffLimitof 3 may be insufficient in environments with:This is particularly problematic for the
velero-upgrade-crdsjob which runs as a Helm pre-install/pre-upgrade hook and can cause installation failures when it exceeds the backoff limit.Changes
upgradeCRDsJob.backoffLimitconfiguration (default: 3)cleanUpCRDsJob.backoffLimitconfiguration (default: 3)labelNamespaceJob.backoffLimitconfiguration (default: 3)Backward Compatibility
✅ All defaults are set to 3, maintaining current behavior.
Usage
Users can now override the backoff limit in their values:
Testing
Related Issues
Addresses scenarios where users encounter
BackoffLimitExceedederrors during Velero installation.