Skip to content

Conversation

@albundy83
Copy link
Contributor

@albundy83 albundy83 commented Sep 4, 2025

Special notes for your reviewer:

Try to fix #698

Checklist

  • DCO signed
  • Chart Version bumped, please refer to the chart version instruction
  • Variables are documented in the values.yaml or README.md
  • Title of the PR starts with chart name (e.g. [velero])

For moment, it's just an idea to remove bitnami kubectl and the need for sh :)

What do you think ?

Signed-off-by: Grégoire Bellon-Gervais <[email protected]>
@albundy83
Copy link
Contributor Author

And I have used the kubernetes version way from this pull request here

Signed-off-by: Grégoire Bellon-Gervais <[email protected]>
Signed-off-by: Grégoire Bellon-Gervais <[email protected]>
Signed-off-by: Grégoire Bellon-Gervais <[email protected]>
Signed-off-by: Grégoire Bellon-Gervais <[email protected]>
Signed-off-by: Grégoire Bellon-Gervais <[email protected]>
Signed-off-by: Grégoire Bellon-Gervais <[email protected]>
@albundy83
Copy link
Contributor Author

Ultimately, I use the work done here for this pull request.

@albundy83 albundy83 mentioned this pull request Sep 8, 2025
4 tasks
@fcuello-fudo
Copy link

@albundy83 do you plan to resume this PR?

@albundy83
Copy link
Contributor Author

Hello,
yes, once this pull has been merged, we should be able to use directly the velero binary to install crds, see this part in upgrade-crds.yaml

......
          command:
            - /velero
          args:
            - install
            - --crds-only
            - --apply
......

and kubectl binary to clean, see those parts in cleanup-crds.yaml:

......
{{/* Define the list of resources to clean up */}}
{{- $cleanupResources := list "restore" "backup" "backupstoragelocation" "volumesnapshotlocation" "podvolumerestore" -}}
......
          command:
            - /bin/kubectl
          args:
            - delete
            - {{ . }}
            - --all
......
          command:
            - /bin/kubectl
          args:
            - delete
            - crd
            - -l
            - component=velero
......

@jenting
Copy link
Collaborator

jenting commented Oct 27, 2025

Is this PR ready to be review? If yes, could you please help address the CI failure? Thanks for your contribution :)

@albundy83
Copy link
Contributor Author

Hello,
As I already explained, unfortunately I need this pull to be merged.

@aviallon
Copy link

@albundy83 the PR just got merged :)

@albundy83
Copy link
Contributor Author

Hello,
yes I see it, very good news :)
Now let's wait for the release

Signed-off-by: Grégoire Bellon-Gervais <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bitnami kubectl image change – migration plan for Velero helm chart

7 participants