-
Notifications
You must be signed in to change notification settings - Fork 402
[velero] Remove bitnami nicely by inverting the original idea #706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Grégoire Bellon-Gervais <[email protected]>
Signed-off-by: Grégoire Bellon-Gervais <[email protected]>
|
And I have used the kubernetes version way from this pull request here |
Signed-off-by: Grégoire Bellon-Gervais <[email protected]>
Signed-off-by: Grégoire Bellon-Gervais <[email protected]>
Signed-off-by: Grégoire Bellon-Gervais <[email protected]>
Signed-off-by: Grégoire Bellon-Gervais <[email protected]>
Signed-off-by: Grégoire Bellon-Gervais <[email protected]>
Signed-off-by: Grégoire Bellon-Gervais <[email protected]>
|
Ultimately, I use the work done here for this pull request. |
Signed-off-by: Grégoire Bellon-Gervais <[email protected]>
|
@albundy83 do you plan to resume this PR? |
|
Hello, ......
command:
- /velero
args:
- install
- --crds-only
- --apply
......and kubectl binary to clean, see those parts in ......
{{/* Define the list of resources to clean up */}}
{{- $cleanupResources := list "restore" "backup" "backupstoragelocation" "volumesnapshotlocation" "podvolumerestore" -}}
......
command:
- /bin/kubectl
args:
- delete
- {{ . }}
- --all
......
command:
- /bin/kubectl
args:
- delete
- crd
- -l
- component=velero
...... |
|
Is this PR ready to be review? If yes, could you please help address the CI failure? Thanks for your contribution :) |
|
Hello, |
|
@albundy83 the PR just got merged :) |
|
Hello, |
Signed-off-by: Grégoire Bellon-Gervais <[email protected]>
Signed-off-by: Grégoire Bellon-Gervais <[email protected]>
Special notes for your reviewer:
Try to fix #698
Checklist
[velero])For moment, it's just an idea to remove bitnami kubectl and the need for sh :)
What do you think ?