Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

array returned by function bypasses illegal sumtype conversion checker error #23271

Open
Le0Developer opened this issue Dec 25, 2024 · 3 comments
Labels
Bug This tag is applied to issues which reports bugs. Status: Confirmed This bug has been confirmed to be valid by a contributor. Unit: Checker Bugs/feature requests, that are related to the type checker.

Comments

@Le0Developer
Copy link
Member

Le0Developer commented Dec 25, 2024

V doctor:

V full version: V 0.4.7 62c69e8.caa0c46
OS: macos, macOS, 15.2, 24C101
Processor: 8 cpus, 64bit, little endian, Apple M2

getwd: /Users/leodev/p/v/cluedo
vexe: /Users/leodev/bin/v/v
vexe mtime: 2024-08-26 08:17:23

vroot: OK, value: /Users/leodev/bin/v
VMODULES: OK, value: /Users/leodev/.vmodules
VTMP: OK, value: /tmp/v_501

Git version: git version 2.39.5 (Apple Git-154)
Git vroot status: weekly.2024.34-46-gcaa0c464 (866 commit(s) behind V master)
.git/config present: true

CC version: Apple clang version 16.0.0 (clang-1600.0.26.6)
thirdparty/tcc status: thirdparty-macos-arm64 713692d4

What did you do?
./v -g -o vdbg cmd/v && ./vdbg repro.v

fn produce_array() []int {
	return [1, 2, 3]
}

type Sumtype = int | string

fn main() {
	mut x := []Sumtype{}
	x << produce_array()

	println(x)
}

What did you expect to see?

Checker error

What did you see instead?

[unknown sum type value, unknown sum type value, unknown sum type value]

Note

You can use the 👍 reaction to increase the issue's priority for developers.

Please note that only the 👍 reaction to the issue itself counts as a vote.
Other reactions and those to comments will not be taken into account.

Huly®: V_0.6-21705

@Le0Developer Le0Developer added the Bug This tag is applied to issues which reports bugs. label Dec 25, 2024
@felipensp felipensp added Status: Confirmed This bug has been confirmed to be valid by a contributor. Unit: cgen Bugs/feature requests, that are related to the default C generating backend. labels Dec 26, 2024
@Le0Developer Le0Developer added Unit: Checker Bugs/feature requests, that are related to the type checker. and removed Unit: cgen Bugs/feature requests, that are related to the default C generating backend. labels Dec 27, 2024
@Le0Developer
Copy link
Member Author

@felipensp this should be a checker error. if you do x << [1, 2, 3] without the function it already is, so this should too

@felipensp
Copy link
Member

felipensp commented Dec 29, 2024

@felipensp this should be a checker error. if you do x << [1, 2, 3] without the function it already is, so this should too

Since x << [1,2,3] //produce_array() works fine, why not keep the behavior for array returned from function?

@Le0Developer
Copy link
Member Author

Since x << [1,2,3] //produce_array() works fine

It doesn’t, it’s a checker error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This tag is applied to issues which reports bugs. Status: Confirmed This bug has been confirmed to be valid by a contributor. Unit: Checker Bugs/feature requests, that are related to the type checker.
Projects
None yet
Development

No branches or pull requests

2 participants