Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed linking with v -cc gcc -parallel-cc examples/sokol/drawing.v, V ignores it, but it should fail too #23209

Open
spytheman opened this issue Dec 19, 2024 · 0 comments
Assignees
Labels
Bug This tag is applied to issues which reports bugs. Build V build error on any OS/CPU architecture. Parallel C Compilation Unit: Compiler Bugs/feature requests, that are related to the V compiler in general.

Comments

@spytheman
Copy link
Member

spytheman commented Dec 19, 2024

V should fail itself, when it detects that either of the parallel C compilation commands failed, and
when it detects that the final serial linking command failed.
Instead, it finished with exit code 0.

Any program that uses sokol currently leads to that, which is a separate problem.

I think, the root cause, is that sokol and other libraries like it, require that only a single .c file have their implementation symbols (see vlib/sokol/c/declaration.c.v:59:#define SOKOL_IMPL), but the current split makes it so that this define is present in several .c files, not just one => the headers are expanded into their implementation version, not their declarative one).

Note

You can use the 👍 reaction to increase the issue's priority for developers.

Please note that only the 👍 reaction to the issue itself counts as a vote.
Other reactions and those to comments will not be taken into account.

Huly®: V_0.6-21645

@spytheman spytheman added Bug This tag is applied to issues which reports bugs. Unit: Compiler Bugs/feature requests, that are related to the V compiler in general. Build V build error on any OS/CPU architecture. Parallel C Compilation labels Dec 19, 2024
@spytheman spytheman self-assigned this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This tag is applied to issues which reports bugs. Build V build error on any OS/CPU architecture. Parallel C Compilation Unit: Compiler Bugs/feature requests, that are related to the V compiler in general.
Projects
None yet
Development

No branches or pull requests

1 participant