You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We recently introduced a new stage comptime for solving compile-time constructs like $if$match... .
I was trying to move more code from cgencomptime_if() to comptime but it required generics to be solved/solvable (because of gen_branch_context_string).
The question is do we solve (once and for all later stages) generics in comptime or do we introduce a new stage for this before comptime? (the new stage would replace the generic AST nodes by new solved ones, cloning the AST for each concrete type, see #26068)
I am in favor of introducing a new stage before comptime so each stage only does one job. Does solving generics have a dependancy on solving comptime constructs?
What do you think of introducing a new generic-solver stage? @kbkpbot@felipensp
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
We recently introduced a new stage
comptimefor solving compile-time constructs like$if$match... .I was trying to move more code from
cgencomptime_if()tocomptimebut it required generics to be solved/solvable (because ofgen_branch_context_string).The question is do we solve (once and for all later stages) generics in
comptimeor do we introduce a new stage for this beforecomptime? (the new stage would replace the generic AST nodes by new solved ones, cloning the AST for each concrete type, see #26068)I am in favor of introducing a new stage before
comptimeso each stage only does one job. Does solving generics have a dependancy on solving comptime constructs?What do you think of introducing a new generic-solver stage?
@kbkpbot @felipensp
Beta Was this translation helpful? Give feedback.
All reactions