From 682512cd4815956701156ac39920d434fee48ac5 Mon Sep 17 00:00:00 2001 From: vlad kobilansky Date: Mon, 8 Jan 2024 12:08:12 -0500 Subject: [PATCH 01/23] adding new flag name --- .github/workflows/pr-only.yaml | 38 +++++++++++++++++----------------- resources/js/classes/person.js | 4 ++++ 2 files changed, 23 insertions(+), 19 deletions(-) diff --git a/.github/workflows/pr-only.yaml b/.github/workflows/pr-only.yaml index a6e0892..8d0a6b1 100644 --- a/.github/workflows/pr-only.yaml +++ b/.github/workflows/pr-only.yaml @@ -73,38 +73,38 @@ jobs: - name: Fix permission #step 2 run: chmod +x codecov - # # RUN tests an upload reports ## comment - # - name: Run Service Testsuite with Coverage - # run: vendor/bin/phpunit --testsuite="Services Tests" --coverage-clover=coverage-service.xml + # RUN tests an upload reports ## comment + - name: Run Service Testsuite with Coverage + run: vendor/bin/phpunit --testsuite="Services Tests" --coverage-clover=coverage-service.xml - # - name: Upload Service coverage report #step 3 - # run: ./codecov ${CODECOV_TOKEN} -F service -f coverage-service.xml + - name: Upload Service coverage report #step 3 + run: ./codecov ${CODECOV_TOKEN} -F service -f coverage-service.xml - # - name: Run Controller Testsuite with Coverage - # run: vendor/bin/phpunit --testsuite="Controllers Tests" --coverage-clover=coverage-controller.xml + - name: Run Controller Testsuite with Coverage + run: vendor/bin/phpunit --testsuite="Controllers Tests" --coverage-clover=coverage-controller.xml - # - name: Upload Controller coverage report - # run: ./codecov -F controller -f coverage-controller.xml + - name: Upload Controller coverage report + run: ./codecov -F controller -f coverage-controller.xml - # - name: Run Unit Testsuite with Coverage - # run: vendor/bin/phpunit --testsuite="Unit Tests" --coverage-clover=coverage-unit.xml + - name: Run Unit Testsuite with Coverage + run: vendor/bin/phpunit --testsuite="Unit Tests" --coverage-clover=coverage-unit.xml - # - name: Upload unit coverage report - # run: ./codecov -F unit -f coverage-unit.xml + - name: Upload unit coverage report + run: ./codecov -F unit -f coverage-unit.xml - name: Run Complete Testsuite with Coverage run: vendor/bin/phpunit --coverage-clover=coverage.xml - # - name: Upload overall coverage report - # run: ./codecov ${CODECOV_TOKEN} -F backend -f coverage.xml + - name: Upload overall coverage report + run: ./codecov ${CODECOV_TOKEN} -F backend -f coverage.xml - name: Upload overall coverage report to another repo run: ./codecov -t ${CODECOV_DD_TOKEN} --url https://doordash.codecov.io -F backend -f coverage.xml - # - name: Javascript tests using Jest - # run: npm run test + - name: Javascript tests using Jest + run: npm run test - # - name: Upload Javascript coverage - # run: ./codecov -F javascript -f coverage/coverage-final.json + - name: Upload Javascript coverage + run: ./codecov -F uu:thisnameis.ridculouslylong-javascrip;but-thisisareally:longnamethatisgoing-tobe;supported-withmanymanycharacters;andthisflagname-istoolongto;dispaly:intheui1234567891011121314151617181920212222324252627282829201212:thisnameis.ridculouslylong-javascrip;but-thisisareally:longnamethatisgoing-tobe;supported-withmanymanycharacters;andthisflagname-istoolongto;dispaly:intheui -f coverage/coverage-final.json \ No newline at end of file diff --git a/resources/js/classes/person.js b/resources/js/classes/person.js index 92c65f7..0e7b3bc 100644 --- a/resources/js/classes/person.js +++ b/resources/js/classes/person.js @@ -37,4 +37,8 @@ getMenuOptions() { return ['menu options']; } + + getPersonalData() { + return 'secret data'; + } } \ No newline at end of file From d6954da1cc18bbf7111bf272a04871c5fd1b84a7 Mon Sep 17 00:00:00 2001 From: vlad kobilansky Date: Mon, 8 Jan 2024 12:14:53 -0500 Subject: [PATCH 02/23] removing sail form updates --- composer.json | 1 - 1 file changed, 1 deletion(-) diff --git a/composer.json b/composer.json index 84933a1..3c7a94f 100644 --- a/composer.json +++ b/composer.json @@ -23,7 +23,6 @@ "mockery/mockery": "^1.4.2", "nunomaduro/collision": "^5.0", "phpunit/phpunit": "^9.3.3", - "yoelpc4/laravel-sail-preset": "^0.1.0" }, "config": { "optimize-autoloader": true, From fea678e290dbb843ff06b5f4ce7891e868358566 Mon Sep 17 00:00:00 2001 From: vlad kobilansky Date: Mon, 8 Jan 2024 12:16:46 -0500 Subject: [PATCH 03/23] remove comma --- composer.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/composer.json b/composer.json index 3c7a94f..e0357b4 100644 --- a/composer.json +++ b/composer.json @@ -22,7 +22,7 @@ "laravel/sail": "^1.0.1", "mockery/mockery": "^1.4.2", "nunomaduro/collision": "^5.0", - "phpunit/phpunit": "^9.3.3", + "phpunit/phpunit": "^9.3.3" }, "config": { "optimize-autoloader": true, From 1a0141b49ac74ddb9c735995ad1ec1a887ffadbb Mon Sep 17 00:00:00 2001 From: vlad kobilansky Date: Mon, 8 Jan 2024 12:21:53 -0500 Subject: [PATCH 04/23] changing flag name to only have dashes --- .github/workflows/pr-only.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-only.yaml b/.github/workflows/pr-only.yaml index 8d0a6b1..27e59da 100644 --- a/.github/workflows/pr-only.yaml +++ b/.github/workflows/pr-only.yaml @@ -105,6 +105,6 @@ jobs: run: npm run test - name: Upload Javascript coverage - run: ./codecov -F uu:thisnameis.ridculouslylong-javascrip;but-thisisareally:longnamethatisgoing-tobe;supported-withmanymanycharacters;andthisflagname-istoolongto;dispaly:intheui1234567891011121314151617181920212222324252627282829201212:thisnameis.ridculouslylong-javascrip;but-thisisareally:longnamethatisgoing-tobe;supported-withmanymanycharacters;andthisflagname-istoolongto;dispaly:intheui -f coverage/coverage-final.json + run: ./codecov -F uu-thisnameis-ridculouslylong-javascrip-but-thisisareally-longnamethatisgoing-tobe-supported-withmanymanycharacters-andthisflagname-istoolongto-dispaly-intheui1234567891011121314151617181920212222324252627282829201212-thisnameis-ridculouslylong-javascrip-but-thisisareally-longnamethatisgoing-tobe-supported-withmanymanycharacters-andthisflagname-istoolongto-dispaly-intheui -f coverage/coverage-final.json \ No newline at end of file From 552d548e3992daa527646c0410d3a871e8662c2e Mon Sep 17 00:00:00 2001 From: vlad kobilansky Date: Mon, 8 Jan 2024 12:28:32 -0500 Subject: [PATCH 05/23] making the name 228 chars --- .github/workflows/pr-only.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-only.yaml b/.github/workflows/pr-only.yaml index 27e59da..d16f791 100644 --- a/.github/workflows/pr-only.yaml +++ b/.github/workflows/pr-only.yaml @@ -105,6 +105,6 @@ jobs: run: npm run test - name: Upload Javascript coverage - run: ./codecov -F uu-thisnameis-ridculouslylong-javascrip-but-thisisareally-longnamethatisgoing-tobe-supported-withmanymanycharacters-andthisflagname-istoolongto-dispaly-intheui1234567891011121314151617181920212222324252627282829201212-thisnameis-ridculouslylong-javascrip-but-thisisareally-longnamethatisgoing-tobe-supported-withmanymanycharacters-andthisflagname-istoolongto-dispaly-intheui -f coverage/coverage-final.json + run: ./codecov -F uu-thisnameis-ridculouslylong-javascrip-but-thisisareally-longnamethatisgoing-tobe-supported-withmanymanycharacters-andthisflagname-istoolongto-dispaly-intheui1234567891011121314151617181920212222324252627282829201212-thisnameis -f coverage/coverage-final.json \ No newline at end of file From 547edd600082993871e1bc8f66ae5acb1602b906 Mon Sep 17 00:00:00 2001 From: vlad kobilansky Date: Tue, 9 Jan 2024 10:07:22 -0500 Subject: [PATCH 06/23] adding crazy flag name back to the setup --- .github/workflows/pr-only.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-only.yaml b/.github/workflows/pr-only.yaml index d16f791..88f5b47 100644 --- a/.github/workflows/pr-only.yaml +++ b/.github/workflows/pr-only.yaml @@ -105,6 +105,6 @@ jobs: run: npm run test - name: Upload Javascript coverage - run: ./codecov -F uu-thisnameis-ridculouslylong-javascrip-but-thisisareally-longnamethatisgoing-tobe-supported-withmanymanycharacters-andthisflagname-istoolongto-dispaly-intheui1234567891011121314151617181920212222324252627282829201212-thisnameis -f coverage/coverage-final.json + run: ./codecov -F uu;:.1234567891011121314151617181920212222324252627282829201212:thisnameis.ridculouslylong-javascrip;but-thisisareally:longnamethatisgoing-tobe;supported-withmanymanycharacters;andthisflagname-istoolongto;dispaly:intheui1234567891011121314151617181920212222324252627282829201212:thisnameis.ridculouslylong-javascrip;but-thisisareally:longnamethatisgoing-tobe;supported-withmanymanycharacters;andthisflagname-istoolongto;dispaly:intheui -f coverage/coverage-final.json \ No newline at end of file From 4985e70c7f56b7222ce2aa554bbb013680b93b93 Mon Sep 17 00:00:00 2001 From: vlad kobilansky Date: Tue, 9 Jan 2024 10:10:28 -0500 Subject: [PATCH 07/23] removing dots --- .github/workflows/pr-only.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-only.yaml b/.github/workflows/pr-only.yaml index 88f5b47..c7826c2 100644 --- a/.github/workflows/pr-only.yaml +++ b/.github/workflows/pr-only.yaml @@ -105,6 +105,6 @@ jobs: run: npm run test - name: Upload Javascript coverage - run: ./codecov -F uu;:.1234567891011121314151617181920212222324252627282829201212:thisnameis.ridculouslylong-javascrip;but-thisisareally:longnamethatisgoing-tobe;supported-withmanymanycharacters;andthisflagname-istoolongto;dispaly:intheui1234567891011121314151617181920212222324252627282829201212:thisnameis.ridculouslylong-javascrip;but-thisisareally:longnamethatisgoing-tobe;supported-withmanymanycharacters;andthisflagname-istoolongto;dispaly:intheui -f coverage/coverage-final.json + run: ./codecov -F uu;:1234567891011121314151617181920212222324252627282829201212:thisnameis:ridculouslylong-javascrip;but-thisisareally:longnamethatisgoing-tobe;supported-withmanymanycharacters;andthisflagname-istoolongto;dispaly:intheui1234567891011121314151617181920212222324252627282829201212:thisnameis#ridculouslylong-javascrip;but-thisisareally:longnamethatisgoing-tobe;supported-withmanymanycharacters;andthisflagname-istoolongto;dispaly:intheui -f coverage/coverage-final.json \ No newline at end of file From 02ef6a555e3cf4502d6bc853228eb7dcd0f0103a Mon Sep 17 00:00:00 2001 From: vlad kobilansky Date: Tue, 9 Jan 2024 10:24:11 -0500 Subject: [PATCH 08/23] adding single quotes --- .github/workflows/pr-only.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-only.yaml b/.github/workflows/pr-only.yaml index c7826c2..9215962 100644 --- a/.github/workflows/pr-only.yaml +++ b/.github/workflows/pr-only.yaml @@ -105,6 +105,6 @@ jobs: run: npm run test - name: Upload Javascript coverage - run: ./codecov -F uu;:1234567891011121314151617181920212222324252627282829201212:thisnameis:ridculouslylong-javascrip;but-thisisareally:longnamethatisgoing-tobe;supported-withmanymanycharacters;andthisflagname-istoolongto;dispaly:intheui1234567891011121314151617181920212222324252627282829201212:thisnameis#ridculouslylong-javascrip;but-thisisareally:longnamethatisgoing-tobe;supported-withmanymanycharacters;andthisflagname-istoolongto;dispaly:intheui -f coverage/coverage-final.json + run: ./codecov -F 'uu;:1234567891011121314151617181920212222324252627282829201212:thisnameis:ridculouslylong-javascrip;but-thisisareally:longnamethatisgoing-tobe;supported-withmanymanycharacters;andthisflagname-istoolongto;dispaly:intheui1234567891011121314151617181920212222324252627282829201212:thisnameis#ridculouslylong-javascrip;but-thisisareally:longnamethatisgoing-tobe;supported-withmanymanycharacters;andthisflagname-istoolongto;dispaly:intheui' -f coverage/coverage-final.json \ No newline at end of file From 2c3052925019beef503959eed95647a1d83f300e Mon Sep 17 00:00:00 2001 From: vlad kobilansky Date: Tue, 9 Jan 2024 10:33:08 -0500 Subject: [PATCH 09/23] trying to swtich to the cli --- .github/workflows/pr-only.yaml | 54 +++++++++++++++++----------------- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/.github/workflows/pr-only.yaml b/.github/workflows/pr-only.yaml index 9215962..db4793d 100644 --- a/.github/workflows/pr-only.yaml +++ b/.github/workflows/pr-only.yaml @@ -50,19 +50,19 @@ jobs: run: npm i ### START Codecov integration ### - - name: Download Codecov binary # step 1 - run: curl -Os https://uploader.codecov.io/latest/linux/codecov + - name: Download Codecov CLI Binary # step 1 + run: curl -Os https://cli.codecov.io/latest/linux/codecov + ### STEPS below are not required, but are great to have for extra security - name: Verify integrity get GPG - run: curl https://keybase.io/codecovsecurity/pgp_keys.asc | gpg --no-default-keyring --keyring trustedkeys.gpg --import # + run: curl https://keybase.io/codecovsecurity/pgp_keys.asc | gpg --no-default-keyring --keyring trustedkeys.gpg --import # One-time step - name: Get SHAsums run: | - curl -Os https://uploader.codecov.io/latest/linux/codecov.SHA256SUM - curl -Os https://uploader.codecov.io/latest/linux/codecov.SHA256SUM.sig - - + curl -Os https://cli.codecov.io/latest/linux/codecov.SHA256SUM + curl -Os https://cli.codecov.io/latest/linux/codecov.SHA256SUM.sig + ## VERIFY integrity - name: Test Signature run: gpgv codecov.SHA256SUM.sig codecov.SHA256SUM @@ -71,40 +71,40 @@ jobs: run: shasum -a 256 -c codecov.SHA256SUM - name: Fix permission #step 2 - run: chmod +x codecov + run: sudo chmod +x codecov # RUN tests an upload reports ## comment - name: Run Service Testsuite with Coverage run: vendor/bin/phpunit --testsuite="Services Tests" --coverage-clover=coverage-service.xml - name: Upload Service coverage report #step 3 - run: ./codecov ${CODECOV_TOKEN} -F service -f coverage-service.xml + run: ./codecov upload-process -t ${CODECOV_TOKEN} -F service -f coverage-service.xml - - name: Run Controller Testsuite with Coverage - run: vendor/bin/phpunit --testsuite="Controllers Tests" --coverage-clover=coverage-controller.xml + # - name: Run Controller Testsuite with Coverage + # run: vendor/bin/phpunit --testsuite="Controllers Tests" --coverage-clover=coverage-controller.xml - - name: Upload Controller coverage report - run: ./codecov -F controller -f coverage-controller.xml + # - name: Upload Controller coverage report + # run: ./codecov -F controller -f coverage-controller.xml - - name: Run Unit Testsuite with Coverage - run: vendor/bin/phpunit --testsuite="Unit Tests" --coverage-clover=coverage-unit.xml + # - name: Run Unit Testsuite with Coverage + # run: vendor/bin/phpunit --testsuite="Unit Tests" --coverage-clover=coverage-unit.xml - - name: Upload unit coverage report - run: ./codecov -F unit -f coverage-unit.xml + # - name: Upload unit coverage report + # run: ./codecov -F unit -f coverage-unit.xml - - name: Run Complete Testsuite with Coverage - run: vendor/bin/phpunit --coverage-clover=coverage.xml + # - name: Run Complete Testsuite with Coverage + # run: vendor/bin/phpunit --coverage-clover=coverage.xml - - name: Upload overall coverage report - run: ./codecov ${CODECOV_TOKEN} -F backend -f coverage.xml + # - name: Upload overall coverage report + # run: ./codecov ${CODECOV_TOKEN} -F backend -f coverage.xml - - name: Upload overall coverage report to another repo - run: ./codecov -t ${CODECOV_DD_TOKEN} --url https://doordash.codecov.io -F backend -f coverage.xml + # - name: Upload overall coverage report to another repo + # run: ./codecov -t ${CODECOV_DD_TOKEN} --url https://doordash.codecov.io -F backend -f coverage.xml - - name: Javascript tests using Jest - run: npm run test + # - name: Javascript tests using Jest + # run: npm run test - - name: Upload Javascript coverage - run: ./codecov -F 'uu;:1234567891011121314151617181920212222324252627282829201212:thisnameis:ridculouslylong-javascrip;but-thisisareally:longnamethatisgoing-tobe;supported-withmanymanycharacters;andthisflagname-istoolongto;dispaly:intheui1234567891011121314151617181920212222324252627282829201212:thisnameis#ridculouslylong-javascrip;but-thisisareally:longnamethatisgoing-tobe;supported-withmanymanycharacters;andthisflagname-istoolongto;dispaly:intheui' -f coverage/coverage-final.json + # - name: Upload Javascript coverage + # run: ./codecov -F 'uu;:1234567891011121314151617181920212222324252627282829201212:thisnameis:ridculouslylong-javascrip;but-thisisareally:longnamethatisgoing-tobe;supported-withmanymanycharacters;andthisflagname-istoolongto;dispaly:intheui1234567891011121314151617181920212222324252627282829201212:thisnameis#ridculouslylong-javascrip;but-thisisareally:longnamethatisgoing-tobe;supported-withmanymanycharacters;andthisflagname-istoolongto;dispaly:intheui' -f coverage/coverage-final.json \ No newline at end of file From cc35599b6111074a2e3a0474f52a0656ed6636e1 Mon Sep 17 00:00:00 2001 From: vlad kobilansky Date: Tue, 9 Jan 2024 10:39:56 -0500 Subject: [PATCH 10/23] adjusting the cli command: --- .github/workflows/pr-only.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-only.yaml b/.github/workflows/pr-only.yaml index db4793d..3a45ca9 100644 --- a/.github/workflows/pr-only.yaml +++ b/.github/workflows/pr-only.yaml @@ -78,7 +78,7 @@ jobs: run: vendor/bin/phpunit --testsuite="Services Tests" --coverage-clover=coverage-service.xml - name: Upload Service coverage report #step 3 - run: ./codecov upload-process -t ${CODECOV_TOKEN} -F service -f coverage-service.xml + run: ./codecov upload-process -t ${secrets.CODECOV_TOKEN} --flag service -f coverage-service.xml # - name: Run Controller Testsuite with Coverage # run: vendor/bin/phpunit --testsuite="Controllers Tests" --coverage-clover=coverage-controller.xml From 37f095ff01b24310176f4ca2946df6b9c6998a4f Mon Sep 17 00:00:00 2001 From: vlad kobilansky Date: Tue, 9 Jan 2024 10:42:58 -0500 Subject: [PATCH 11/23] adjusting token back to old command --- .github/workflows/pr-only.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-only.yaml b/.github/workflows/pr-only.yaml index 3a45ca9..69a4761 100644 --- a/.github/workflows/pr-only.yaml +++ b/.github/workflows/pr-only.yaml @@ -78,7 +78,7 @@ jobs: run: vendor/bin/phpunit --testsuite="Services Tests" --coverage-clover=coverage-service.xml - name: Upload Service coverage report #step 3 - run: ./codecov upload-process -t ${secrets.CODECOV_TOKEN} --flag service -f coverage-service.xml + run: ./codecov upload-process -t ${CODECOV_TOKEN} --flag service -f coverage-service.xml # - name: Run Controller Testsuite with Coverage # run: vendor/bin/phpunit --testsuite="Controllers Tests" --coverage-clover=coverage-controller.xml From 132286879a637c4e988dc4cbe1ce8470fc97d062 Mon Sep 17 00:00:00 2001 From: vlad kobilansky Date: Tue, 9 Jan 2024 11:20:31 -0500 Subject: [PATCH 12/23] adjusting flag param --- .github/workflows/pr-only.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-only.yaml b/.github/workflows/pr-only.yaml index 69a4761..4643437 100644 --- a/.github/workflows/pr-only.yaml +++ b/.github/workflows/pr-only.yaml @@ -78,7 +78,7 @@ jobs: run: vendor/bin/phpunit --testsuite="Services Tests" --coverage-clover=coverage-service.xml - name: Upload Service coverage report #step 3 - run: ./codecov upload-process -t ${CODECOV_TOKEN} --flag service -f coverage-service.xml + run: ./codecov upload-process -t ${CODECOV_TOKEN} --flag=service -f coverage-service.xml # - name: Run Controller Testsuite with Coverage # run: vendor/bin/phpunit --testsuite="Controllers Tests" --coverage-clover=coverage-controller.xml From a16984ba6e20b7ff656db5ff4018c3d0eb4da5ad Mon Sep 17 00:00:00 2001 From: vlad kobilansky Date: Tue, 9 Jan 2024 11:40:43 -0500 Subject: [PATCH 13/23] adjusting flag param --- .github/workflows/pr-only.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-only.yaml b/.github/workflows/pr-only.yaml index 4643437..d94026e 100644 --- a/.github/workflows/pr-only.yaml +++ b/.github/workflows/pr-only.yaml @@ -78,7 +78,7 @@ jobs: run: vendor/bin/phpunit --testsuite="Services Tests" --coverage-clover=coverage-service.xml - name: Upload Service coverage report #step 3 - run: ./codecov upload-process -t ${CODECOV_TOKEN} --flag=service -f coverage-service.xml + run: ./codecov upload-process -t ${CODECOV_TOKEN} --flag 'service' -f coverage-service.xml # - name: Run Controller Testsuite with Coverage # run: vendor/bin/phpunit --testsuite="Controllers Tests" --coverage-clover=coverage-controller.xml @@ -99,7 +99,7 @@ jobs: # run: ./codecov ${CODECOV_TOKEN} -F backend -f coverage.xml # - name: Upload overall coverage report to another repo - # run: ./codecov -t ${CODECOV_DD_TOKEN} --url https://doordash.codecov.io -F backend -f coverage.xml + # run: ./codecov -t ${CODECOV_DD_TOKEN} --url https://codecov.io -F backend -f coverage.xml # - name: Javascript tests using Jest # run: npm run test From 8f6ad4443433541cfe6268f31dc22dbb83bf858a Mon Sep 17 00:00:00 2001 From: vlad kobilansky Date: Tue, 9 Jan 2024 11:48:29 -0500 Subject: [PATCH 14/23] adjusting flag param --- .github/workflows/pr-only.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-only.yaml b/.github/workflows/pr-only.yaml index d94026e..ea72f1a 100644 --- a/.github/workflows/pr-only.yaml +++ b/.github/workflows/pr-only.yaml @@ -78,7 +78,7 @@ jobs: run: vendor/bin/phpunit --testsuite="Services Tests" --coverage-clover=coverage-service.xml - name: Upload Service coverage report #step 3 - run: ./codecov upload-process -t ${CODECOV_TOKEN} --flag 'service' -f coverage-service.xml + run: ./codecov upload-process -t ${{ secrets.CODECOV_TOKEN }} --flag service -f coverage-service.xml # - name: Run Controller Testsuite with Coverage # run: vendor/bin/phpunit --testsuite="Controllers Tests" --coverage-clover=coverage-controller.xml From 29372af0a2ba5af2f92f27521694a5fe5656e312 Mon Sep 17 00:00:00 2001 From: vlad kobilansky Date: Tue, 9 Jan 2024 11:54:42 -0500 Subject: [PATCH 15/23] adjusting commands for the cli --- .github/workflows/pr-only.yaml | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pr-only.yaml b/.github/workflows/pr-only.yaml index ea72f1a..19437e3 100644 --- a/.github/workflows/pr-only.yaml +++ b/.github/workflows/pr-only.yaml @@ -78,7 +78,12 @@ jobs: run: vendor/bin/phpunit --testsuite="Services Tests" --coverage-clover=coverage-service.xml - name: Upload Service coverage report #step 3 - run: ./codecov upload-process -t ${{ secrets.CODECOV_TOKEN }} --flag service -f coverage-service.xml + env: # Or as an environment variable + CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} + run: | + codecov --verbose create-commit --fail-on-error + codecov --verbose create-report --fail-on-error + codecov --verbose do-upload --fail-on-error --flag service --name service-tests # - name: Run Controller Testsuite with Coverage # run: vendor/bin/phpunit --testsuite="Controllers Tests" --coverage-clover=coverage-controller.xml From 4c67c43b5594bfe3a6e2bb9f1278b502c115aa03 Mon Sep 17 00:00:00 2001 From: vlad kobilansky Date: Tue, 9 Jan 2024 12:28:41 -0500 Subject: [PATCH 16/23] adjusting to pip install --- .github/workflows/pr-only.yaml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/pr-only.yaml b/.github/workflows/pr-only.yaml index 19437e3..3bba009 100644 --- a/.github/workflows/pr-only.yaml +++ b/.github/workflows/pr-only.yaml @@ -81,9 +81,11 @@ jobs: env: # Or as an environment variable CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} run: | - codecov --verbose create-commit --fail-on-error - codecov --verbose create-report --fail-on-error - codecov --verbose do-upload --fail-on-error --flag service --name service-tests + pip install --user pytest + pip install --user codecov-cli + codecov-cli --verbose create-commit --fail-on-error + codecov-cli --verbose create-report --fail-on-error + codecov-cli --verbose do-upload --fail-on-error --flag service -f coverage-service.xml # - name: Run Controller Testsuite with Coverage # run: vendor/bin/phpunit --testsuite="Controllers Tests" --coverage-clover=coverage-controller.xml From 2d99784e25a56bab004994420bcfe563cd84b4d6 Mon Sep 17 00:00:00 2001 From: vlad kobilansky Date: Tue, 9 Jan 2024 12:31:22 -0500 Subject: [PATCH 17/23] adjusting to no dash --- .github/workflows/pr-only.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/pr-only.yaml b/.github/workflows/pr-only.yaml index 3bba009..c2ae7c4 100644 --- a/.github/workflows/pr-only.yaml +++ b/.github/workflows/pr-only.yaml @@ -83,9 +83,9 @@ jobs: run: | pip install --user pytest pip install --user codecov-cli - codecov-cli --verbose create-commit --fail-on-error - codecov-cli --verbose create-report --fail-on-error - codecov-cli --verbose do-upload --fail-on-error --flag service -f coverage-service.xml + codecovcli --verbose create-commit --fail-on-error + codecovcli --verbose create-report --fail-on-error + codecovcli --verbose do-upload --fail-on-error --flag service -f coverage-service.xml # - name: Run Controller Testsuite with Coverage # run: vendor/bin/phpunit --testsuite="Controllers Tests" --coverage-clover=coverage-controller.xml From 63030b03202c3e9086140531a30933f5d0f31d3d Mon Sep 17 00:00:00 2001 From: vlad kobilansky Date: Wed, 10 Jan 2024 09:50:51 -0500 Subject: [PATCH 18/23] changing param name --- .github/workflows/pr-only.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-only.yaml b/.github/workflows/pr-only.yaml index c2ae7c4..391f1d0 100644 --- a/.github/workflows/pr-only.yaml +++ b/.github/workflows/pr-only.yaml @@ -85,7 +85,7 @@ jobs: pip install --user codecov-cli codecovcli --verbose create-commit --fail-on-error codecovcli --verbose create-report --fail-on-error - codecovcli --verbose do-upload --fail-on-error --flag service -f coverage-service.xml + codecovcli --verbose do-upload --fail-on-error -F service -f coverage-service.xml # - name: Run Controller Testsuite with Coverage # run: vendor/bin/phpunit --testsuite="Controllers Tests" --coverage-clover=coverage-controller.xml From a2d5d59473cc67452d473dc6cbb5f85505865756 Mon Sep 17 00:00:00 2001 From: vlad kobilansky Date: Wed, 10 Jan 2024 11:17:49 -0500 Subject: [PATCH 19/23] trying to simplify cli usage --- .github/workflows/pr-only.yaml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/workflows/pr-only.yaml b/.github/workflows/pr-only.yaml index 391f1d0..8a8d9e6 100644 --- a/.github/workflows/pr-only.yaml +++ b/.github/workflows/pr-only.yaml @@ -81,11 +81,7 @@ jobs: env: # Or as an environment variable CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} run: | - pip install --user pytest - pip install --user codecov-cli - codecovcli --verbose create-commit --fail-on-error - codecovcli --verbose create-report --fail-on-error - codecovcli --verbose do-upload --fail-on-error -F service -f coverage-service.xml + codecov --verbose upload-process --fail-on-error -F service -f coverage-service.xml # - name: Run Controller Testsuite with Coverage # run: vendor/bin/phpunit --testsuite="Controllers Tests" --coverage-clover=coverage-controller.xml From 09ba708e4519b157ebae14f44eb2619410aac6d6 Mon Sep 17 00:00:00 2001 From: vlad kobilansky Date: Wed, 10 Jan 2024 11:33:38 -0500 Subject: [PATCH 20/23] trying to add dot slash --- .github/workflows/pr-only.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-only.yaml b/.github/workflows/pr-only.yaml index 8a8d9e6..bc5ed0b 100644 --- a/.github/workflows/pr-only.yaml +++ b/.github/workflows/pr-only.yaml @@ -81,7 +81,7 @@ jobs: env: # Or as an environment variable CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} run: | - codecov --verbose upload-process --fail-on-error -F service -f coverage-service.xml + ./codecov --verbose upload-process --fail-on-error -F service -f coverage-service.xml # - name: Run Controller Testsuite with Coverage # run: vendor/bin/phpunit --testsuite="Controllers Tests" --coverage-clover=coverage-controller.xml From ed3285c9282c48643a3b50a2729ed2692edd164a Mon Sep 17 00:00:00 2001 From: vlad kobilansky Date: Fri, 12 Jan 2024 11:20:47 -0500 Subject: [PATCH 21/23] adding name and adjust the flow for the js upload --- .github/workflows/pr-only.yaml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/pr-only.yaml b/.github/workflows/pr-only.yaml index bc5ed0b..487097e 100644 --- a/.github/workflows/pr-only.yaml +++ b/.github/workflows/pr-only.yaml @@ -81,7 +81,7 @@ jobs: env: # Or as an environment variable CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} run: | - ./codecov --verbose upload-process --fail-on-error -F service -f coverage-service.xml + ./codecov --verbose upload-process --fail-on-error -n 'service'${{ github.run_id }} -F service -f coverage-service.xml # - name: Run Controller Testsuite with Coverage # run: vendor/bin/phpunit --testsuite="Controllers Tests" --coverage-clover=coverage-controller.xml @@ -107,7 +107,10 @@ jobs: # - name: Javascript tests using Jest # run: npm run test - # - name: Upload Javascript coverage - # run: ./codecov -F 'uu;:1234567891011121314151617181920212222324252627282829201212:thisnameis:ridculouslylong-javascrip;but-thisisareally:longnamethatisgoing-tobe;supported-withmanymanycharacters;andthisflagname-istoolongto;dispaly:intheui1234567891011121314151617181920212222324252627282829201212:thisnameis#ridculouslylong-javascrip;but-thisisareally:longnamethatisgoing-tobe;supported-withmanymanycharacters;andthisflagname-istoolongto;dispaly:intheui' -f coverage/coverage-final.json + - name: Upload Javascript coverage + env: # Or as an environment variable + CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} + run: | + ./codecov --verbose upload-process --fail-on-error -n 'javascript'${{ github.run_id }} -F 'uu;:1234567891011121314151617181920212222324252627282829201212:thisnameis:ridculouslylong-javascrip;but-thisisareally:longnamethatisgoing-tobe;supported-withmanymanycharacters;andthisflagname-istoolongto;dispaly:intheui1234567891011121314151617181920212222324252627282829201212:thisnameis#ridculouslylong-javascrip;but-thisisareally:longnamethatisgoing-tobe;supported-withmanymanycharacters;andthisflagname-istoolongto;dispaly:intheui' -f coverage/coverage-final.json \ No newline at end of file From 7387e721155c18a28039b7591d093d3e5cf42111 Mon Sep 17 00:00:00 2001 From: vlad kobilansky Date: Fri, 12 Jan 2024 12:37:06 -0500 Subject: [PATCH 22/23] moving token inline --- .github/workflows/pr-only.yaml | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/.github/workflows/pr-only.yaml b/.github/workflows/pr-only.yaml index 487097e..be9ae70 100644 --- a/.github/workflows/pr-only.yaml +++ b/.github/workflows/pr-only.yaml @@ -15,8 +15,8 @@ jobs: --health-interval=10s --health-timeout=5s --health-retries=3 - steps: + steps: - name: Checkout app code uses: actions/checkout@v2 with: @@ -78,10 +78,7 @@ jobs: run: vendor/bin/phpunit --testsuite="Services Tests" --coverage-clover=coverage-service.xml - name: Upload Service coverage report #step 3 - env: # Or as an environment variable - CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} - run: | - ./codecov --verbose upload-process --fail-on-error -n 'service'${{ github.run_id }} -F service -f coverage-service.xml + run: ./codecov --verbose upload-process --fail-on-error -t ${{ secrets.CODECOV_TOKEN }} -n 'service'${{ github.run_id }} -F service -f coverage-service.xml # - name: Run Controller Testsuite with Coverage # run: vendor/bin/phpunit --testsuite="Controllers Tests" --coverage-clover=coverage-controller.xml From 6c093328b2730bc10c5b10f45a3e6559f2a2dee2 Mon Sep 17 00:00:00 2001 From: vlad kobilansky Date: Fri, 12 Jan 2024 13:13:39 -0500 Subject: [PATCH 23/23] adjusting workflow to use the cli --- .github/workflows/pr-only.yaml | 38 ++++++++++++++-------------------- 1 file changed, 16 insertions(+), 22 deletions(-) diff --git a/.github/workflows/pr-only.yaml b/.github/workflows/pr-only.yaml index be9ae70..fe0c562 100644 --- a/.github/workflows/pr-only.yaml +++ b/.github/workflows/pr-only.yaml @@ -78,36 +78,30 @@ jobs: run: vendor/bin/phpunit --testsuite="Services Tests" --coverage-clover=coverage-service.xml - name: Upload Service coverage report #step 3 - run: ./codecov --verbose upload-process --fail-on-error -t ${{ secrets.CODECOV_TOKEN }} -n 'service'${{ github.run_id }} -F service -f coverage-service.xml + run: ./codecov --verbose upload-process --fail-on-error -t ${{ secrets.CODECOV_TOKEN }} -n 'service'-${{ github.run_id }} -F service -f coverage-service.xml - # - name: Run Controller Testsuite with Coverage - # run: vendor/bin/phpunit --testsuite="Controllers Tests" --coverage-clover=coverage-controller.xml + - name: Run Controller Testsuite with Coverage + run: vendor/bin/phpunit --testsuite="Controllers Tests" --coverage-clover=coverage-controller.xml - # - name: Upload Controller coverage report - # run: ./codecov -F controller -f coverage-controller.xml + - name: Upload Controller coverage report + run: ./codecov --verbose upload-process --fail-on-error -t ${{ secrets.CODECOV_TOKEN }} -n 'controller'-${{ github.run_id }} -F controller -f coverage-service.xml - # - name: Run Unit Testsuite with Coverage - # run: vendor/bin/phpunit --testsuite="Unit Tests" --coverage-clover=coverage-unit.xml + - name: Run Unit Testsuite with Coverage + run: vendor/bin/phpunit --testsuite="Unit Tests" --coverage-clover=coverage-unit.xml - # - name: Upload unit coverage report - # run: ./codecov -F unit -f coverage-unit.xml + - name: Upload unit coverage report + run: ./codecov --verbose upload-process --fail-on-error -t ${{ secrets.CODECOV_TOKEN }} -n 'unit'-${{ github.run_id }} -F unit -f coverage-unit.xml - # - name: Run Complete Testsuite with Coverage - # run: vendor/bin/phpunit --coverage-clover=coverage.xml + - name: Run Complete Testsuite with Coverage + run: vendor/bin/phpunit --coverage-clover=coverage.xml - # - name: Upload overall coverage report - # run: ./codecov ${CODECOV_TOKEN} -F backend -f coverage.xml + - name: Upload overall coverage report + run: ./codecov --verbose upload-process --fail-on-error -t ${{ secrets.CODECOV_TOKEN }} -n 'backend'-${{ github.run_id }} -F backend -f coverage.xml - # - name: Upload overall coverage report to another repo - # run: ./codecov -t ${CODECOV_DD_TOKEN} --url https://codecov.io -F backend -f coverage.xml - - # - name: Javascript tests using Jest - # run: npm run test + - name: Javascript tests using Jest + run: npm run test - name: Upload Javascript coverage - env: # Or as an environment variable - CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} - run: | - ./codecov --verbose upload-process --fail-on-error -n 'javascript'${{ github.run_id }} -F 'uu;:1234567891011121314151617181920212222324252627282829201212:thisnameis:ridculouslylong-javascrip;but-thisisareally:longnamethatisgoing-tobe;supported-withmanymanycharacters;andthisflagname-istoolongto;dispaly:intheui1234567891011121314151617181920212222324252627282829201212:thisnameis#ridculouslylong-javascrip;but-thisisareally:longnamethatisgoing-tobe;supported-withmanymanycharacters;andthisflagname-istoolongto;dispaly:intheui' -f coverage/coverage-final.json + run: ./codecov --verbose upload-process --fail-on-error -t ${{ secrets.CODECOV_TOKEN }} -n 'javascript'-${{ github.run_id }} -F 'javascript' -f coverage/coverage-final.json \ No newline at end of file