Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphAnalyzer: refine stat.hasVideo #2066

Open
esaruoho opened this issue Oct 21, 2017 · 0 comments
Open

graphAnalyzer: refine stat.hasVideo #2066

esaruoho opened this issue Oct 21, 2017 · 0 comments

Comments

@esaruoho
Copy link
Contributor

originally posted by @gmarinov

since iOS10, silent videos are allowed to autoplay

graphAnalyser.js:

if (videoPlugins.indexOf(id) > -1) {
  stat.hasAudio = true
  stat.hasVideo = true
}

... marks all experiences using video with .hasAudio=true regardless of whether the video actually has sound. It would be beneficial to check the video asset(s) in question.

more information: https://webkit.org/blog/6784/new-video-policies-for-ios/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant